Merged
Conversation
We're treating this as a soundness fix. Technically this is breaking MSRV, but we believe this will not be observed by any of our users.
folkertdev
commented
Feb 28, 2025
Comment on lines
71
to
74
| #[no_mangle] | ||
| pub fn bz_internal_error(errcode: c_int) { | ||
| pub extern "C" fn bz_internal_error(errcode: c_int) { | ||
| panic!("bz internal error: {}", errcode); | ||
| } |
Member
Author
There was a problem hiding this comment.
do we need to use extern "system" on windows given our MSRV?
Collaborator
There was a problem hiding this comment.
extern "system" is the same as extern "C" except on 32bit Windows where it is the same as extern "stdcall". bzip2 uses extern "stdcall" for all BZ2_* methods on 32bit Windows, but uses the regular C ABI for bz_internal_error.
bjorn3
approved these changes
Feb 28, 2025
This was referenced Feb 28, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're treating this as a soundness fix. While currently using the rust ABI happens to work, it might (in theory) break at any point in the future.
Technically this is breaking semver compatibility, but we believe this will not be observed by any of our users.Bumping the MSRV of a
-syscrate causes a lot of duplicate dependencies and ecosystem churn, so it's something that we'd rather avoid.