Added Rust 1.86.0 and 2024 edition support#138
Closed
kamikaze wants to merge 1 commit intotrifectatechfoundation:masterfrom
bixority:feature/rust-2024-edition
Closed
Added Rust 1.86.0 and 2024 edition support#138kamikaze wants to merge 1 commit intotrifectatechfoundation:masterfrom bixority:feature/rust-2024-edition
kamikaze wants to merge 1 commit intotrifectatechfoundation:masterfrom
bixority:feature/rust-2024-edition
Conversation
Member
|
Sorry, but we very deliberately support older versions of rust. That means the code looks ancient and weird, but it's the price we pay for keeping older systems working. Also especially for |
bjorn3
requested changes
Apr 9, 2025
| name = "bzip2-sys" | ||
| version = "0.1.13+1.0.8" | ||
| version = "0.2.0" | ||
| edition = "2024" |
Collaborator
There was a problem hiding this comment.
Aside from what @folkertdev said, for bzip2-sys specifically: There can be only a single version of the bzip2-sys crate inside a cargo workspace. As such a semver incompatible bump has a huge cost for all users of bzip2-rs. I think any benefit of using the 2024 edition is significantly lower than the cost.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi. I would like to get a code review from you :) Also maybe someday this change will be handy :)