Closed
Conversation
folkertdev
commented
Apr 16, 2025
| edition = "2021" | ||
| name = "bzip2" | ||
| version = "0.5.2" | ||
| version = "0.5.3" |
Member
Author
There was a problem hiding this comment.
is this change worth a major version bump? I'd say no, because the exported C symbols are an implementation detail. But technically it could break something
Collaborator
There was a problem hiding this comment.
I don't think we need a major version bump.
folkertdev
force-pushed
the
bump-libbz2-rs-sys-0.2.0
branch
from
2750733 to
8aa585a
Compare
bjorn3
approved these changes
May 28, 2025
Collaborator
bjorn3
left a comment
bjorn3
left a comment
There was a problem hiding this comment.
Completely missed this PR.
Member
Author
|
at this point, let's wait for the audit to be done so that we can incorporate any improvements. That should give us a version that we can make the default in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.