Merged
Conversation
bjorn3
reviewed
Jan 6, 2026
| username, | ||
| self.packet_sender.clone(), | ||
| ) { | ||
| self.inner = Some(service); |
Collaborator
There was a problem hiding this comment.
Maybe instead provide a way for a service to replace itself with another service by returning it from handle_packet?
Collaborator
Author
There was a problem hiding this comment.
Then the behavior of silently ignoring the authentication messages as required by RFC4252 section 5.3 wont work, as those would count as unimplemented for the other service, resulting in an unimplemented response instead.
davidv1992
force-pushed
the
auth-service
branch
2 times, most recently
from
d5cf23f to
25d7e70
Compare
davidv1992
force-pushed
the
auth-service
branch
from
25d7e70 to
341a170
Compare
bjorn3
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of the authentication service. Also includes some minor changes to the service handling to deal with a minor design flaw.
Note: server currently crashes after auth due to some mac failure. I propose we solve this in a separate PR.