Ensure packets are a multiple of the cipher block size#21
Merged
Conversation
davidv1992
requested changes
Jan 6, 2026
Collaborator
davidv1992
left a comment
davidv1992
left a comment
There was a problem hiding this comment.
Strongly prefer to split this as the second commit will cause conflicts with #14 and the steps afterwards, and once that is in also isn't really needed.
bjorn3
force-pushed
the
bjorn3/fix_padding
branch
from
fb826f4 to
b7d1010
Compare
davidv1992
requested changes
Jan 6, 2026
Collaborator
davidv1992
left a comment
davidv1992
left a comment
There was a problem hiding this comment.
Missed 1 part of the bug
| let min_padding = 8 - (buf.len() - start) % 8; | ||
| let block_size = cipher_block_len.max(8); | ||
| let min_padding = block_size - (buf.len() - start) % block_size; | ||
| let padding_len = match min_padding < 4 { |
Collaborator
There was a problem hiding this comment.
You are missing 1 potential part of the bug here, namely that the packet also needs to be at least 16 bytes long.
davidv1992
approved these changes
Jan 6, 2026
Collaborator
|
Changed my mind, we can do the second part in a separate PR if thats desirable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18