Loop match proper errors #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folkertdev
commented
Mar 13, 2025
Comment on lines
+906
to
+912
| fn local(expr: &rustc_hir::Expr<'_>) -> Option<hir::HirId> { | ||
| if let hir::ExprKind::Path(hir::QPath::Resolved(_, path)) = expr.kind { | ||
| if let Res::Local(hir_id) = path.res { | ||
| return Some(hir_id); | ||
| } | ||
| } | ||
|
|
||
| None | ||
| } |
Member
Author
There was a problem hiding this comment.
ideally this would be a method somewhere, but I'm not sure where that should be
Collaborator
There was a problem hiding this comment.
Not sure either. Can be left for later.
folkertdev
force-pushed
the
loop-match-proper-errors
branch
2 times, most recently
from
f5122c3 to
18ac1ea
Compare
folkertdev
force-pushed
the
loop-match-proper-errors
branch
from
18ac1ea to
2265cb4
Compare
bjorn3
reviewed
Mar 13, 2025
| Ok(target_id) => { | ||
| let Some(value) = value else { | ||
| let span = expr.span; | ||
| self.tcx.dcx().emit_fatal(ConstContinueMissingValue { span }) |
Collaborator
There was a problem hiding this comment.
Ideally this would be a regular error and produce ExprKind::Err instead.
Member
Author
There was a problem hiding this comment.
there is no error variant for this type I think? https://doc.rust-lang.org/nightly/nightly-rustc/rustc_middle/thir/enum.ExprKind.html
Collaborator
|
Can you tick the checkbox for better errors in the todo file? |
bjorn3
approved these changes
Mar 13, 2025
folkertdev
merged commit eb82562
into
trifectatechfoundation:loop_match_attr
1 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.