fix: uninstalling sudo after sudo-rs is installed will break sudo-rs on some distros #1301
+80
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users might not know that uninstalling sudo after sudo-rs is installed might lock them out of their systems. This corrects that. Doc change only.
…/sudo missing instantly making sudo-rs fail without a proper error message (#1) * Make missing file errors tell which files are missing * Clearer error message for missing /etc/sudoers & /etc/sudoers-rs files * Ensure PAM service config is present under linux & freebsd before erroring on user for a random reason
Pingasmaster
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users might not know that uninstalling sudo after sudo-rs is installed might lock them out of their systems. This corrects that. The doc is changed for arch linux (where I was able to reproduce the issue on a fresh build) as well as a potential fix for:
These two issues arise from #1182.
I think we should at least let users know about this issue until we fix it one way or another. Currently, uninstalling sudo after installing sudo-rs causes files to go missing on arch linux systems, and therefore critical sudo-rs failure, locking the user out of its system from 2 different causes.
Please be kind, this is my first real contribution to a rust project, so I don't have a lot of prior experience in rust-based code. I tried my best, feel free to tell me whats wrong.