Allow non-UTF-8 arguments in sudo#1413
Merged
bjorn3 merged 8 commits intotrifectatechfoundation:mainfrom Feb 16, 2026
Merged
Conversation
squell
reviewed
Jan 8, 2026
bjorn3
force-pushed
the
args_os_str
branch
2 times, most recently
from
a39ce9f to
1d660d8
Compare
Collaborator
Author
|
Blocked on #1438 |
bjorn3
force-pushed
the
args_os_str
branch
4 times, most recently
from
f0b6f43 to
db99a97
Compare
Member
|
I saw a few easy nits (especially the UTF8 errors peppered throughout the CLI were making the cognitive load higher, and as it's an ad-hoc parser...) that I pushed. For the rest, see below. |
squell
reviewed
Feb 13, 2026
squell
approved these changes
Feb 13, 2026
This matches og-sudo
su and visudo don't allow it yet and non-UTF-8 arguments are only passed through for the command to execute. Not for env vars and paths.
squell
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
su and visudo don't allow it yet and non-UTF-8 arguments are only passed
through for the command to execute. Not for env vars and paths.
An alternative would be to use
env::args_os()but immediately reject non-UTF-8 arguments with a nice error message rather than a panic like currently happens.Fixes #1412