Skip to content

Comments

Remove obsoleted bash script#1427

Merged
squell merged 3 commits intomainfrom
remove-lcov-info
Feb 9, 2026
Merged

Remove obsoleted bash script#1427
squell merged 3 commits intomainfrom
remove-lcov-info

Conversation

@squell
Copy link
Member

@squell squell commented Jan 27, 2026

It was only used for generating / combining coverage data from the test framework. But that cannot be done "in production mode"; please see the compliance-coverage branch for an updated and improved version of this script (and the associated changes necessary to use it meaningfully).

@squell squell added this to the Improve testing framework milestone Jan 27, 2026
@squell squell added minor minor issue, PR without an issue test-framework labels Jan 27, 2026
@squell squell requested a review from rnijveld January 27, 2026 23:14
@squell squell force-pushed the remove-lcov-info branch 2 times, most recently from 89535d1 to 6b0a56f Compare January 27, 2026 23:49
@squell
Copy link
Member Author

squell commented Jan 27, 2026

By the "boy scout rule", this also makes this change (and similar ones in the unit tests):

 /// Check whether a path points to a regular file and any executable flag is set
-pub(crate) fn is_valid_executable(path: &PathBuf) -> bool {
+pub(crate) fn is_valid_executable(path: &Path) -> bool {
     if path.is_file() {

Since having a &PathBuf as an argument to a function is a bit strange; and the only reason it was done was to avoid having to write a closure.

@squell
Copy link
Member Author

squell commented Jan 27, 2026

I didn't release the crucial role this bash script was playing in our automated tests. All the more reason to remove it.

bad-antics

This comment was marked as spam.

bad-antics

This comment was marked as duplicate.

@trifectatechfoundation trifectatechfoundation locked as spam and limited conversation to collaborators Feb 2, 2026
@trifectatechfoundation trifectatechfoundation unlocked this conversation Feb 6, 2026
@squell squell requested a review from bjorn3 February 9, 2026 13:31
@squell squell enabled auto-merge (squash) February 9, 2026 13:32
@squell squell removed the request for review from rnijveld February 9, 2026 13:34
@squell squell merged commit b0f0a87 into main Feb 9, 2026
18 checks passed
@squell squell deleted the remove-lcov-info branch February 9, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor minor issue, PR without an issue test-framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants