Conversation
89535d1 to
6b0a56f
Compare
Member
Author
|
By the "boy scout rule", this also makes this change (and similar ones in the unit tests): /// Check whether a path points to a regular file and any executable flag is set
-pub(crate) fn is_valid_executable(path: &PathBuf) -> bool {
+pub(crate) fn is_valid_executable(path: &Path) -> bool {
if path.is_file() {Since having a |
6b0a56f to
4a6eef3
Compare
Member
Author
|
I didn't release the crucial role this bash script was playing in our automated tests. All the more reason to remove it. |
bjorn3
reviewed
Feb 9, 2026
dcea3c6 to
d12489a
Compare
bjorn3
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was only used for generating / combining coverage data from the test framework. But that cannot be done "in production mode"; please see the compliance-coverage branch for an updated and improved version of this script (and the associated changes necessary to use it meaningfully).