enhance JSON error handling #208
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add JSON parsing validation to throw a specific error for invalid JSON syntax - Update error handling in createFromUrl action to provide clearer feedback for invalid JSON errors - Maintain existing functionality while improving user feedback on errors
ArjunCodess
changed the title
ArjunCodess
changed the title
|
@matt-aitken hey! :) if there is anything left to implement / anything to be edited, please let me know! |
|
(closed it by mistake, im sorry) |
|
@matt-aitken just a follow-up. |
1 similar comment
|
@matt-aitken just a follow-up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #77
Changes:
isJSON()to returnfalseinstead of throwing errorscreateFromUrlOrRawJson()createFromUrl.tsto show "Invalid JSON" with actual parsing errorBefore: Generic "Unknown error" for invalid JSON
After: Clear error messages like "Invalid JSON: Expected double-quoted property name in JSON at position 27"
Files changed:
app/jsonDoc.server.tsapp/routes/actions/createFromUrl.ts