fix: Logging large objects is now much more performant and uses less memory (#2263)

* Logging large objects performance fixes

* Add changeset

* docs: new otel attribute count defaults

* Scope the switch/case statement with braces

* Add tests for nested map and sets

---------

Co-authored-by: nicktrn <[email protected]>

Author: ericallam

.changeset/chatty-snakes-hope.md

@@ -0,0 +1,5 @@
+---
+"@trigger.dev/sdk": patch
+---
+
+fix: Logging large objects is now much more performant and uses less memory

apps/webapp/app/env.server.ts

@@ -283,8 +283,8 @@ const EnvironmentSchema = z.object({
   PROD_OTEL_LOG_EXPORT_TIMEOUT_MILLIS: z.string().default("30000"),
   PROD_OTEL_LOG_MAX_QUEUE_SIZE: z.string().default("512"),
 
-  TRIGGER_OTEL_SPAN_ATTRIBUTE_COUNT_LIMIT: z.string().default("256"),
-  TRIGGER_OTEL_LOG_ATTRIBUTE_COUNT_LIMIT: z.string().default("256"),
+  TRIGGER_OTEL_SPAN_ATTRIBUTE_COUNT_LIMIT: z.string().default("1024"),
+  TRIGGER_OTEL_LOG_ATTRIBUTE_COUNT_LIMIT: z.string().default("1024"),
   TRIGGER_OTEL_SPAN_ATTRIBUTE_VALUE_LENGTH_LIMIT: z.string().default("131072"),
   TRIGGER_OTEL_LOG_ATTRIBUTE_VALUE_LENGTH_LIMIT: z.string().default("131072"),
   TRIGGER_OTEL_SPAN_EVENT_COUNT_LIMIT: z.string().default("10"),

docs/self-hosting/env/webapp.mdx

@@ -105,8 +105,8 @@ mode: "wide"
 | `MAXIMUM_DEV_QUEUE_SIZE`                         | No       | —                     | Max dev queue size.                                                                                       |
 | `MAXIMUM_DEPLOYED_QUEUE_SIZE`                    | No       | —                     | Max deployed queue size.                                                                                  |
 | **OTel limits**                                  |          |                       |                                                                                                           |
-| `TRIGGER_OTEL_SPAN_ATTRIBUTE_COUNT_LIMIT`        | No       | 256                   | OTel span attribute count limit.                                                                          |
-| `TRIGGER_OTEL_LOG_ATTRIBUTE_COUNT_LIMIT`         | No       | 256                   | OTel log attribute count limit.                                                                           |
+| `TRIGGER_OTEL_SPAN_ATTRIBUTE_COUNT_LIMIT`        | No       | 1024                  | OTel span attribute count limit.                                                                          |
+| `TRIGGER_OTEL_LOG_ATTRIBUTE_COUNT_LIMIT`         | No       | 1024                  | OTel log attribute count limit.                                                                           |
 | `TRIGGER_OTEL_SPAN_ATTRIBUTE_VALUE_LENGTH_LIMIT` | No       | 131072                | OTel span attribute value length limit.                                                                   |
 | `TRIGGER_OTEL_LOG_ATTRIBUTE_VALUE_LENGTH_LIMIT`  | No       | 131072                | OTel log attribute value length limit.                                                                    |
 | `TRIGGER_OTEL_SPAN_EVENT_COUNT_LIMIT`            | No       | 10                    | OTel span event count limit.                                                                              |

packages/cli-v3/src/entryPoints/dev-run-worker.ts

@@ -15,6 +15,7 @@ import {
   localsAPI,
   logger,
   LogLevel,
+  OTEL_LOG_ATTRIBUTE_COUNT_LIMIT,
   resourceCatalog,
   runMetadata,
   runtime,
@@ -191,7 +192,8 @@ async function doBootstrap() {
       typeof config.enableConsoleLogging === "boolean" ? config.enableConsoleLogging : true,
       typeof config.disableConsoleInterceptor === "boolean"
         ? config.disableConsoleInterceptor
-        : false
+        : false,
+      OTEL_LOG_ATTRIBUTE_COUNT_LIMIT
     );
 
     const configLogLevel = triggerLogLevel ?? config.logLevel ?? "info";
@@ -200,6 +202,7 @@ async function doBootstrap() {
       logger: otelLogger,
       tracer: tracer,
       level: logLevels.includes(configLogLevel as any) ? (configLogLevel as LogLevel) : "info",
+      maxAttributeCount: OTEL_LOG_ATTRIBUTE_COUNT_LIMIT,
     });
 
     logger.setGlobalTaskLogger(otelTaskLogger);

packages/cli-v3/src/entryPoints/managed-run-worker.ts

@@ -14,6 +14,7 @@ import {
   localsAPI,
   logger,
   LogLevel,
+  OTEL_LOG_ATTRIBUTE_COUNT_LIMIT,
   resourceCatalog,
   runMetadata,
   runtime,
@@ -182,7 +183,8 @@ async function doBootstrap() {
       typeof config.enableConsoleLogging === "boolean" ? config.enableConsoleLogging : true,
       typeof config.disableConsoleInterceptor === "boolean"
         ? config.disableConsoleInterceptor
-        : false
+        : false,
+      OTEL_LOG_ATTRIBUTE_COUNT_LIMIT
     );
 
     const configLogLevel = triggerLogLevel ?? config.logLevel ?? "info";
@@ -191,6 +193,7 @@ async function doBootstrap() {
       logger: otelLogger,
       tracer: tracer,
       level: logLevels.includes(configLogLevel as any) ? (configLogLevel as LogLevel) : "info",
+      maxAttributeCount: OTEL_LOG_ATTRIBUTE_COUNT_LIMIT,
     });
 
     logger.setGlobalTaskLogger(otelTaskLogger);

packages/core/src/v3/consoleInterceptor.ts

@@ -11,7 +11,8 @@ export class ConsoleInterceptor {
   constructor(
     private readonly logger: logsAPI.Logger,
     private readonly sendToStdIO: boolean,
-    private readonly interceptingDisabled: boolean
+    private readonly interceptingDisabled: boolean,
+    private readonly maxAttributeCount?: number
   ) {}
 
   // Intercept the console and send logs to the OpenTelemetry logger
@@ -92,7 +93,10 @@ export class ConsoleInterceptor {
         severityNumber,
         severityText,
         body: getLogMessage(parsed.value, severityText),
-        attributes: { ...this.#getAttributes(severityNumber), ...flattenAttributes(parsed.value) },
+        attributes: {
+          ...this.#getAttributes(severityNumber),
+          ...flattenAttributes(parsed.value, undefined, this.maxAttributeCount),
+        },
         timestamp,
       });
 

packages/core/src/v3/limits.ts

@@ -13,11 +13,11 @@ function getOtelEnvVarLimit(key: string, defaultValue: number) {
 
 export const OTEL_SPAN_ATTRIBUTE_COUNT_LIMIT = getOtelEnvVarLimit(
   "TRIGGER_OTEL_SPAN_ATTRIBUTE_COUNT_LIMIT",
-  256
+  1024
 );
 export const OTEL_LOG_ATTRIBUTE_COUNT_LIMIT = getOtelEnvVarLimit(
   "TRIGGER_OTEL_LOG_ATTRIBUTE_COUNT_LIMIT",
-  256
+  1024
 );
 export const OTEL_SPAN_ATTRIBUTE_VALUE_LENGTH_LIMIT = getOtelEnvVarLimit(
   "TRIGGER_OTEL_SPAN_ATTRIBUTE_VALUE_LENGTH_LIMIT",
@@ -51,10 +51,6 @@ export function imposeAttributeLimits(attributes: Attributes): Attributes {
       continue;
     }
 
-    if (Object.keys(newAttributes).length >= OTEL_SPAN_ATTRIBUTE_COUNT_LIMIT) {
-      break;
-    }
-
     newAttributes[key] = value;
   }
 

packages/core/src/v3/logger/taskLogger.ts

@@ -16,6 +16,7 @@ export type TaskLoggerConfig = {
   logger: Logger;
   tracer: TriggerTracer;
   level: LogLevel;
+  maxAttributeCount?: number;
 };
 
 export type TraceOptions = Prettify<
@@ -78,7 +79,12 @@ export class OtelTaskLogger implements TaskLogger {
     severityNumber: SeverityNumber,
     properties?: Record<string, unknown>
   ) {
-    let attributes: Attributes = { ...flattenAttributes(safeJsonProcess(properties)) };
+    let attributes: Attributes = {};
+
+    if (properties) {
+      // Use flattenAttributes directly - it now handles all non-JSON friendly values efficiently
+      attributes = flattenAttributes(properties, undefined, this._config.maxAttributeCount);
+    }
 
     const icon = iconStringForSeverity(severityNumber);
     if (icon !== undefined) {
@@ -136,23 +142,3 @@ export class NoopTaskLogger implements TaskLogger {
     return {} as Span;
   }
 }
-
-function safeJsonProcess(value?: Record<string, unknown>): Record<string, unknown> | undefined {
-  try {
-    return JSON.parse(JSON.stringify(value, jsonErrorReplacer));
-  } catch {
-    return value;
-  }
-}
-
-function jsonErrorReplacer(key: string, value: unknown) {
-  if (value instanceof Error) {
-    return {
-      name: value.name,
-      message: value.message,
-      stack: value.stack,
-    };
-  }
-
-  return value;
-}