Skip to content

Commit f2bdc64

Browse files
samejrsamejr
committed
Revert "Adds to={path} to the TableRow only"
This reverts commit 8a814d4.
1 parent 8a814d4 commit f2bdc64

File tree

2 files changed

+32
-24
lines changed

2 files changed

+32
-24
lines changed

‎apps/webapp/app/components/runs/v3/TaskRunsTable.tsx‎

Lines changed: 24 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,7 @@ export function TaskRunsTable({
283283
runs.map((run, index) => {
284284
const path = v3RunSpanPath(organization, project, run, { spanId: run.spanId });
285285
return (
286-
<TableRow to={path} key={run.id}>
286+
<TableRow key={run.id}>
287287
{allowSelection && (
288288
<TableCell className="pl-3 pr-0">
289289
<Checkbox
@@ -298,29 +298,33 @@ export function TaskRunsTable({
298298
/>
299299
</TableCell>
300300
)}
301-
<TableCell alignment="right">{formatNumber(run.number)}</TableCell>
302-
<TableCell>
301+
<TableCell to={path} alignment="right">
302+
{formatNumber(run.number)}
303+
</TableCell>
304+
<TableCell to={path}>
303305
<EnvironmentLabel
304306
environment={run.environment}
305307
userName={run.environment.userName}
306308
/>
307309
</TableCell>
308-
<TableCell>
310+
<TableCell to={path}>
309311
<span className="flex items-center gap-x-1">
310312
{run.taskIdentifier}
311313
{run.rootTaskRunId === null ? <Badge variant="extra-small">Root</Badge> : null}
312314
</span>
313315
</TableCell>
314-
<TableCell>{run.version ?? "–"}</TableCell>
315-
<TableCell>
316+
<TableCell to={path}>{run.version ?? "–"}</TableCell>
317+
<TableCell to={path}>
316318
<SimpleTooltip
317319
content={descriptionForTaskRunStatus(run.status)}
318320
disableHoverableContent
319321
button={<TaskRunStatusCombo status={run.status} />}
320322
/>
321323
</TableCell>
322-
<TableCell>{run.startedAt ? <DateTime date={run.startedAt} /> : "–"}</TableCell>
323-
<TableCell className="w-[1%]" actionClassName="pr-0 tabular-nums">
324+
<TableCell to={path}>
325+
{run.startedAt ? <DateTime date={run.startedAt} /> : "–"}
326+
</TableCell>
327+
<TableCell to={path} className="w-[1%]" actionClassName="pr-0 tabular-nums">
324328
<div className="flex items-center gap-1">
325329
<RectangleStackIcon className="size-4 text-text-dimmed" />
326330
{run.startedAt ? (
@@ -336,7 +340,7 @@ export function TaskRunsTable({
336340
)}
337341
</div>
338342
</TableCell>
339-
<TableCell className="w-[1%]" actionClassName="px-4 tabular-nums">
343+
<TableCell to={path} className="w-[1%]" actionClassName="px-4 tabular-nums">
340344
<div className="flex items-center gap-1">
341345
<ClockIcon className="size-4 text-blue-500" />
342346
{run.startedAt && run.finishedAt ? (
@@ -350,7 +354,7 @@ export function TaskRunsTable({
350354
)}
351355
</div>
352356
</TableCell>
353-
<TableCell actionClassName="pl-0 tabular-nums">
357+
<TableCell to={path} actionClassName="pl-0 tabular-nums">
354358
<div className="flex items-center gap-1">
355359
<CpuChipIcon className="size-4 text-success" />
356360
{run.usageDurationMs > 0
@@ -361,17 +365,21 @@ export function TaskRunsTable({
361365
</div>
362366
</TableCell>
363367
{showCompute && (
364-
<TableCell className="tabular-nums">
368+
<TableCell to={path} className="tabular-nums">
365369
{run.costInCents > 0 ? formatCurrencyAccurate(run.costInCents / 100) : "–"}
366370
</TableCell>
367371
)}
368-
<TableCell>
372+
<TableCell to={path}>
369373
{run.isTest ? <CheckIcon className="size-4 text-charcoal-400" /> : "–"}
370374
</TableCell>
371-
<TableCell>{run.createdAt ? <DateTime date={run.createdAt} /> : "–"}</TableCell>
372-
<TableCell>{run.delayUntil ? <DateTime date={run.delayUntil} /> : "–"}</TableCell>
373-
<TableCell>{run.ttl ?? "–"}</TableCell>
374-
<TableCell actionClassName="py-1">
375+
<TableCell to={path}>
376+
{run.createdAt ? <DateTime date={run.createdAt} /> : "–"}
377+
</TableCell>
378+
<TableCell to={path}>
379+
{run.delayUntil ? <DateTime date={run.delayUntil} /> : "–"}
380+
</TableCell>
381+
<TableCell to={path}>{run.ttl ?? "–"}</TableCell>
382+
<TableCell to={path} actionClassName="py-1">
375383
<div className="flex gap-1">
376384
{run.tags.map((tag) => <RunTag key={tag} tag={tag} />) || "–"}
377385
</div>

‎apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.v3.$projectParam._index/route.tsx‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -279,8 +279,8 @@ export default function Page() {
279279
: v3TestPath(organization, project);
280280

281281
return (
282-
<TableRow to={path} key={task.slug} className="group">
283-
<TableCell>
282+
<TableRow key={task.slug} className="group">
283+
<TableCell to={path}>
284284
<div className="flex items-center gap-2">
285285
<SimpleTooltip
286286
button={<TaskTriggerSourceIcon source={task.triggerSource} />}
@@ -289,13 +289,13 @@ export default function Page() {
289289
<span>{task.slug}</span>
290290
</div>
291291
</TableCell>
292-
<TableCell>
292+
<TableCell to={path}>
293293
<TaskFunctionName
294294
functionName={task.exportName}
295295
variant="extra-extra-small"
296296
/>
297297
</TableCell>
298-
<TableCell>
298+
<TableCell to={path}>
299299
<Suspense
300300
fallback={
301301
<>
@@ -311,7 +311,7 @@ export default function Page() {
311311
</TypedAwait>
312312
</Suspense>
313313
</TableCell>
314-
<TableCell>
314+
<TableCell to={path}>
315315
<Suspense fallback={<></>}>
316316
<TypedAwait resolve={runningStats}>
317317
{(data) => {
@@ -321,7 +321,7 @@ export default function Page() {
321321
</TypedAwait>
322322
</Suspense>
323323
</TableCell>
324-
<TableCell>
324+
<TableCell to={path}>
325325
<Suspense fallback={<TaskActivityBlankState />}>
326326
<TypedAwait resolve={activity}>
327327
{(data) => {
@@ -341,7 +341,7 @@ export default function Page() {
341341
</TypedAwait>
342342
</Suspense>
343343
</TableCell>
344-
<TableCell>
344+
<TableCell to={path}>
345345
<Suspense fallback={<></>}>
346346
<TypedAwait resolve={durations}>
347347
{(data) => {
@@ -355,7 +355,7 @@ export default function Page() {
355355
</TypedAwait>
356356
</Suspense>
357357
</TableCell>
358-
<TableCell>
358+
<TableCell to={path}>
359359
<EnvironmentLabels environments={task.environments} />
360360
</TableCell>
361361
<TableCellMenu

0 commit comments

Comments
 (0)