Skip to content

Conversation

matt-aitken
Copy link
Member

Sometimes runs weren't continuing when their children were complete. This is for triggerAndWait and batchTriggerAndWait.

Changes

  • Added a new service that gets given a run and figures out if there are dependencies and then schedules a resume if it makes sense
  • In the finalize run service, set a final attempt status/error if passed in. Created a final attempt if there isn't one.
  • If Graphile addJob throws an error then we return an undefined job instead of throwing.
  • Don't resume the same batch multiple times

Copy link

changeset-bot bot commented Sep 6, 2024

🦋 Changeset detected

Latest commit: bc958d1

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Sep 6, 2024

pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/build@1286
pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev@1286
pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/core@1286
pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/sdk@1286

commit: bc958d1

@matt-aitken
Copy link
Member Author

Test cancelling from the dashboard and SDK

@matt-aitken matt-aitken merged commit 392453e into main Sep 9, 2024
10 checks passed
@matt-aitken matt-aitken deleted the frozen-runs branch September 9, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant