Skip to content

Conversation

@ericallam
Copy link
Member

Fixes an issue where we were showing version mismatch errors because we are comparing the CLI version with the exact version string for @trigger.dev/sdk as specified in package.json dependencies. So for example, if the package.json looked like this:

{
  "dependencies": "^3.0.0"
}

The CLI would print out this warning when using [email protected]:

CleanShot 2024-09-16 at 15 56 19

The fix is to actually resolve the version as found in the package.json of the real package on disk.

@changeset-bot
Copy link

changeset-bot bot commented Sep 16, 2024

🦋 Changeset detected

Latest commit: b89fa35

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@trigger.dev/sdk Patch
trigger.dev Patch
@trigger.dev/build Patch
@trigger.dev/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ericallam ericallam force-pushed the v3/fix-3.0.0-update-warning branch from 5ea8849 to dcc1dcb Compare September 16, 2024 16:39
@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 16, 2024

pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/build@1308
pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev@1308
pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/core@1308
pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/sdk@1308

commit: b89fa35

@ericallam ericallam merged commit 3aa5811 into main Sep 16, 2024
@ericallam ericallam deleted the v3/fix-3.0.0-update-warning branch September 16, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants