Skip to content

Fix dotenv overrides for dev runs #1388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 8, 2024
Merged

Fix dotenv overrides for dev runs #1388

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb9bbb6
override dashboard dev env vars with local .env
nicktrn Oct 7, 2024
6ad5f05
add changeset
nicktrn Oct 7, 2024
4bed455
add simple task for testing env vars
nicktrn Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/gentle-mails-smoke.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"trigger.dev": patch
---

Local env files like `.env` will now correctly override dev env vars configured in the dashboard
2 changes: 1 addition & 1 deletion packages/cli-v3/src/dev/backgroundWorker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,9 +319,9 @@ export class BackgroundWorker {
const processOptions: TaskRunProcessOptions = {
payload,
env: {
...sanitizeEnvVars(this.params.env),
// TODO: this needs the stripEmptyValues stuff too
...sanitizeEnvVars(payload.environment ?? {}),
...sanitizeEnvVars(this.params.env),
TRIGGER_WORKER_MANIFEST_PATH: this.workerManifestPath,
},
serverWorker: this.serverWorker,
Expand Down