Skip to content

Make ephemeral storage defaults configurable via env vars #1407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 16, 2024
Merged

Make ephemeral storage defaults configurable via env vars #1407

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
98acc78
Added support for the env vars `POD_EPHEMERAL_STORAGE_SIZE_LIMIT` and…
iFlyinq Oct 14, 2024
4fa8076
Reverted pnpm lockfile
iFlyinq Oct 14, 2024
9ddfb77
Made sure there is no diff between the main lockfile & PR's lockfile
iFlyinq Oct 14, 2024
d8cca79
Not touching the storage for the index containers
iFlyinq Oct 14, 2024
ee0fb7e
Not touching the storage for the prePull container
iFlyinq Oct 14, 2024
82c9406
Merge branch 'triggerdotdev:main' into main
iFlyinq Oct 15, 2024
4ab2134
Merge branch 'main' into main
iFlyinq Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions apps/kubernetes-provider/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ const UPTIME_MAX_PENDING_RUNS = Number(process.env.UPTIME_MAX_PENDING_RUNS || "2
const UPTIME_MAX_PENDING_INDECES = Number(process.env.UPTIME_MAX_PENDING_INDECES || "10");
const UPTIME_MAX_PENDING_ERRORS = Number(process.env.UPTIME_MAX_PENDING_ERRORS || "10");

const POD_EPHEMERAL_STORAGE_SIZE_LIMIT = process.env.POD_EPHEMERAL_STORAGE_SIZE_LIMIT || "10Gi";
const POD_EPHEMERAL_STORAGE_SIZE_REQUEST = process.env.POD_EPHEMERAL_STORAGE_SIZE_REQUEST || "2Gi";

const logger = new SimpleLogger(`[${NODE_NAME}]`);
logger.log(`running in ${RUNTIME_ENV} mode`);

Expand Down Expand Up @@ -108,7 +111,7 @@ class KubernetesTaskOperations implements TaskOperations {
limits: {
cpu: "1",
memory: "2G",
"ephemeral-storage": "2Gi",
"ephemeral-storage": POD_EPHEMERAL_STORAGE_SIZE_LIMIT,
},
},
lifecycle: {
Expand Down Expand Up @@ -338,7 +341,10 @@ class KubernetesTaskOperations implements TaskOperations {
limits: {
cpu: "0.25",
memory: "100Mi",
"ephemeral-storage": "1Gi",
"ephemeral-storage": POD_EPHEMERAL_STORAGE_SIZE_LIMIT,
},
requests: {
"ephemeral-storage": POD_EPHEMERAL_STORAGE_SIZE_REQUEST,
},
},
},
Expand Down Expand Up @@ -396,13 +402,13 @@ class KubernetesTaskOperations implements TaskOperations {

get #defaultResourceRequests(): ResourceQuantities {
return {
"ephemeral-storage": "2Gi",
"ephemeral-storage": POD_EPHEMERAL_STORAGE_SIZE_REQUEST,
};
}

get #defaultResourceLimits(): ResourceQuantities {
return {
"ephemeral-storage": "10Gi",
"ephemeral-storage": POD_EPHEMERAL_STORAGE_SIZE_LIMIT,
};
}

Expand Down
Loading
Loading