Skip to content

Unflattening array fix for very large arrays #1432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Unflattening array fix for very large arrays #1432

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
653e0b5
fix unflattening of array indices
nicktrn Oct 23, 2024
d78da87
Get tests passing
ericallam Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 21 additions & 11 deletions packages/core/src/v3/utils/flattenAttributes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,16 +95,26 @@ export function unflattenAttributes(
const result: Record<string, unknown> = {};

for (const [key, value] of Object.entries(obj)) {
const parts = key.split(".").reduce((acc, part) => {
if (part.includes("[")) {
// Handling nested array indices
const subparts = part.split(/\[|\]/).filter((p) => p !== "");
acc.push(...subparts);
} else {
acc.push(part);
}
return acc;
}, [] as string[]);
const parts = key.split(".").reduce(
(acc, part) => {
if (part.includes("[")) {
// Handling nested array indices
const match = part.match(/^\[(\d+)\]$/);
const number = match?.[1];

if (number) {
acc.push(parseInt(number));
return acc;
}

acc.push(part.replace("[", "").replace("]", ""));
} else {
acc.push(part);
}
return acc;
},
[] as (string | number)[]
);

let current: any = result;
for (let i = 0; i < parts.length - 1; i++) {
Expand All @@ -115,7 +125,7 @@ export function unflattenAttributes(
}

const nextPart = parts[i + 1];
const isArray = nextPart && /^\d+$/.test(nextPart);
const isArray = typeof nextPart === "number";
if (isArray && !Array.isArray(current[part])) {
current[part] = [];
} else if (!isArray && current[part] === undefined) {
Expand Down