Skip to content

Adds Realtime concurrency limits to the billing page pricing tiers #1500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Adds Realtime concurrency limits to the billing page pricing tiers #1500

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions apps/webapp/app/routes/resources.orgs.$organizationSlug.select-plan.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,11 @@ const pricingDefinitions = {
content:
"A single email address, Slack channel, or webhook URL that you want to send alerts to.",
},
realtime: {
title: "Realtime connections",
content:
"Realtime allows you to send the live status and data from your runs to your frontend. This is the number of simultaneous Realtime connections that can be made.",
},
};

type PricingPlansProps = {
Expand Down Expand Up @@ -494,6 +499,7 @@ export function TierFree({
<LogRetention limits={plan.limits} />
<SupportLevel limits={plan.limits} />
<Alerts limits={plan.limits} />
<RealtimeConnecurrency limits={plan.limits} />
Copy link
Contributor

@coderabbitai coderabbitai bot Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Update component references after fixing the typo

After renaming the component from RealtimeConnecurrency to RealtimeConcurrency, update all references:

Apply this diff to update the references:

-            <RealtimeConnecurrency limits={plan.limits} />
+            <RealtimeConcurrency limits={plan.limits} />

Also applies to: 617-617, 688-688

</ul>
</>
)}
Expand Down Expand Up @@ -608,6 +614,7 @@ export function TierHobby({
<LogRetention limits={plan.limits} />
<SupportLevel limits={plan.limits} />
<Alerts limits={plan.limits} />
<RealtimeConnecurrency limits={plan.limits} />
</ul>
</TierContainer>
);
Expand Down Expand Up @@ -678,6 +685,7 @@ export function TierPro({
<LogRetention limits={plan.limits} />
<SupportLevel limits={plan.limits} />
<Alerts limits={plan.limits} />
<RealtimeConnecurrency limits={plan.limits} />
</ul>
</TierContainer>
);
Expand Down Expand Up @@ -950,3 +958,18 @@ function Alerts({ limits }: { limits: Limits }) {
</FeatureItem>
);
}

function RealtimeConnecurrency({ limits }: { limits: Limits }) {
return (
<FeatureItem checked>
{limits.realtimeConcurrentConnections.number}
{limits.realtimeConcurrentConnections.canExceed ? "+" : ""}{" "}
<DefinitionTip
title={pricingDefinitions.realtime.title}
content={pricingDefinitions.realtime.content}
>
concurrent Realtime connections
</DefinitionTip>
</FeatureItem>
);
}
Comment on lines +962 to +975
Copy link
Contributor

@coderabbitai coderabbitai bot Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix typo in component name: "Connecurrency" → "Concurrency"

The component name contains a typo that should be corrected for clarity and consistency.

Apply this diff to fix the typo:

-function RealtimeConnecurrency({ limits }: { limits: Limits }) {
+function RealtimeConcurrency({ limits }: { limits: Limits }) {
   return (
     <FeatureItem checked>
       {limits.realtimeConcurrentConnections.number}
       {limits.realtimeConcurrentConnections.canExceed ? "+" : ""}{" "}
       <DefinitionTip
         title={pricingDefinitions.realtime.title}
         content={pricingDefinitions.realtime.content}
       >
         concurrent Realtime connections
       </DefinitionTip>
     </FeatureItem>
   );
 }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
function RealtimeConnecurrency({ limits }: { limits: Limits }) {
return (
<FeatureItem checked>
{limits.realtimeConcurrentConnections.number}
{limits.realtimeConcurrentConnections.canExceed ? "+" : ""}{" "}
<DefinitionTip
title={pricingDefinitions.realtime.title}
content={pricingDefinitions.realtime.content}
>
concurrent Realtime connections
</DefinitionTip>
</FeatureItem>
);
}
function RealtimeConcurrency({ limits }: { limits: Limits }) {
return (
<FeatureItem checked>
{limits.realtimeConcurrentConnections.number}
{limits.realtimeConcurrentConnections.canExceed ? "+" : ""}{" "}
<DefinitionTip
title={pricingDefinitions.realtime.title}
content={pricingDefinitions.realtime.content}
>
concurrent Realtime connections
</DefinitionTip>
</FeatureItem>
);
}

Loading