Skip to content

Fix: Prevent hung worker process on flush exceptions #1501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Fix: Prevent hung worker process on flush exceptions #1501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8d4d01c
deprecate cli logger warn and error methods
nicktrn Nov 27, 2024
1b513c3
replace broken error logger in deployed workers
nicktrn Nov 27, 2024
1e5b400
changeset
nicktrn Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/ninety-teachers-fold.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"trigger.dev": patch
---

Prevent certain log statements from hanging deployed worker processes
4 changes: 2 additions & 2 deletions packages/cli-v3/src/executions/taskRunProcess.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ export class TaskRunProcess {
try {
await this.#flush();
} catch (err) {
logger.error("Error flushing task run process", { err });
console.error("Error flushing task run process", { err });
}

await this.kill();
Expand All @@ -94,7 +94,7 @@ export class TaskRunProcess {
try {
await this.#flush();
} catch (err) {
logger.error("Error flushing task run process", { err });
console.error("Error flushing task run process", { err });
}

if (kill) {
Expand Down
2 changes: 2 additions & 0 deletions packages/cli-v3/src/utilities/logger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,9 @@ export class Logger {
};
info = (...args: unknown[]) => this.doLog("info", args);
log = (...args: unknown[]) => this.doLog("log", args);
/** @deprecated **ONLY USE THIS IN THE CLI** - It will hang the process when used in deployed code (!) */
warn = (...args: unknown[]) => this.doLog("warn", args);
/** @deprecated **ONLY USE THIS IN THE CLI** - It will hang the process when used in deployed code (!) */
error = (...args: unknown[]) => this.doLog("error", args);
table<Keys extends string>(data: TableRow<Keys>[], level?: Exclude<LoggerLevel, "none">) {
const keys: Keys[] = data.length === 0 ? [] : (Object.keys(data[0]!) as Keys[]);
Expand Down