Skip to content

Adds more org names to the alert emails #1561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 30, 2024
Merged

Adds more org names to the alert emails #1561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f16fb4
Adds more org names to the alert emails
samejr Dec 13, 2024
ef7e976
Merge branch 'main' into adds-org-name-to-alert-emails
samejr Dec 19, 2024
db91e2a
Merge branch 'main' into adds-org-name-to-alert-emails
matt-aitken Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion internal-packages/emails/emails/deployment-failure.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,9 @@ export default function Email(props: z.infer<typeof AlertDeploymentFailureEmailS
<Preview>{`[${organization}] Deployment ${version} [${environment}] failed: ${error.name}`}</Preview>
<Body style={main}>
<Container style={container}>
<Text style={h1}>{`An error occurred deploying ${version} in ${environment}`}</Text>
<Text
style={h1}
>{`An error occurred deploying ${version} in ${environment} in your ${organization} organization`}</Text>
<Text style={paragraphLight}>
{error.name} {error.message}
</Text>
Expand Down
2 changes: 1 addition & 1 deletion internal-packages/emails/emails/deployment-success.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export default function Email(props: z.infer<typeof AlertDeploymentSuccessEmailS
<Container style={container}>
<Text
style={h1}
>{`Version ${version} successfully deployed ${taskCount} tasks in ${environment}`}</Text>
>{`Version ${version} successfully deployed ${taskCount} tasks in ${environment} in your ${organization} organization`}</Text>

<Link
href={deploymentLink}
Expand Down
8 changes: 4 additions & 4 deletions internal-packages/emails/src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,25 +103,25 @@ export class EmailClient {
};
case "alert-attempt": {
return {
subject: `Error on ${data.taskIdentifier} [${data.version}.${data.environment}] ${data.error.message}`,
subject: `[${data.organization}] Error on ${data.taskIdentifier} [${data.version}.${data.environment}] ${data.error.message}`,
component: <AlertAttemptFailureEmail {...data} />,
};
}
case "alert-run": {
return {
subject: `Run ${data.runId} failed for ${data.taskIdentifier} [${data.version}.${data.environment}] ${data.error.message}`,
subject: `[${data.organization}] Run ${data.runId} failed for ${data.taskIdentifier} [${data.version}.${data.environment}] ${data.error.message}`,
component: <AlertRunFailureEmail {...data} />,
};
}
case "alert-deployment-failure": {
return {
subject: `Deployment ${data.version} [${data.environment}] failed: ${data.error.name}`,
subject: `[${data.organization}] Deployment ${data.version} [${data.environment}] failed: ${data.error.name}`,
component: <AlertDeploymentFailureEmail {...data} />,
};
}
case "alert-deployment-success": {
return {
subject: `Deployment ${data.version} [${data.environment}] succeeded`,
subject: `[${data.organization}] Deployment ${data.version} [${data.environment}] succeeded`,
component: <AlertDeploymentSuccessEmail {...data} />,
};
}
Expand Down