Skip to content

Fix "crypto is not defined error" on Node.js 18 in dev #1623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 20, 2025
Merged

Fix "crypto is not defined error" on Node.js 18 in dev #1623

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c6da669
Add --experimental-global-webcrypto node option fix "crypto is not de…
ericallam Jan 18, 2025
ab2a58c
Only add flag when on node 18
ericallam Jan 18, 2025
e21c112
Missed the function
ericallam Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/green-cheetahs-scream.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@trigger.dev/core": patch
---

Add --experimental-global-webcrypto node option fix "crypto is not defined error" on Node.js 18 in dev
7 changes: 6 additions & 1 deletion packages/core/src/v3/build/runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,12 @@ export function execOptionsForRuntime(runtime: BuildRuntime, options: ExecOption

const conditions = options.customConditions?.map((condition) => `--conditions=${condition}`);

return [importEntryPoint, conditions, process.env.NODE_OPTIONS]
return [
importEntryPoint,
conditions,
process.env.NODE_OPTIONS,
"--experimental-global-webcrypto",
]
.filter(Boolean)
.flat()
.join(" ");
Expand Down
Loading