Skip to content

engine v1 improved dequeue selection algorithm #1632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 23, 2025
Merged

engine v1 improved dequeue selection algorithm #1632

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
82eceec
engine v1 fairness improvements (env based queue selection)
ericallam Jan 23, 2025
565762b
Add ability to bias env selection by concurrency limit and capacity
ericallam Jan 23, 2025
7a6dfe2
Add some randomization to the list of queues within each evn
ericallam Jan 23, 2025
e28b823
Configure biases using env vars
ericallam Jan 23, 2025
46e722c
Typo
ericallam Jan 23, 2025
b7e4f69
revert v3 catalog project ref change
ericallam Jan 23, 2025
268a354
Fix v2 marqs
ericallam Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .vscode/launch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,15 @@
"cwd": "${workspaceFolder}/apps/webapp",
"sourceMaps": true
},
{
"type": "node-terminal",
"request": "launch",
"name": "Debug fairDequeuingStrategy.test.ts",
"command": "pnpm run test -t FairDequeuingStrategy",
"envFile": "${workspaceFolder}/.env",
"cwd": "${workspaceFolder}/apps/webapp",
"sourceMaps": true
},
{
"type": "chrome",
"request": "launch",
Expand Down
9 changes: 7 additions & 2 deletions apps/webapp/app/env.server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,8 @@ const EnvironmentSchema = z.object({
INTERNAL_OTEL_TRACE_INSTRUMENT_PRISMA_ENABLED: z.string().default("0"),
INTERNAL_OTEL_TRACE_DISABLED: z.string().default("0"),

INTERNAL_OTEL_LOG_EXPORTER_URL: z.string().optional(),

ORG_SLACK_INTEGRATION_CLIENT_ID: z.string().optional(),
ORG_SLACK_INTEGRATION_CLIENT_SECRET: z.string().optional(),

Expand All @@ -221,9 +223,12 @@ const EnvironmentSchema = z.object({
.number()
.int()
.default(60 * 1000 * 15),
MARQS_SHARED_QUEUE_SELECTION_COUNT: z.coerce.number().int().default(36),
MARQS_DEV_QUEUE_SELECTION_COUNT: z.coerce.number().int().default(12),
MARQS_SHARED_QUEUE_LIMIT: z.coerce.number().int().default(1000),
MARQS_DEV_QUEUE_LIMIT: z.coerce.number().int().default(1000),
MARQS_MAXIMUM_NACK_COUNT: z.coerce.number().int().default(64),
MARQS_CONCURRENCY_LIMIT_BIAS: z.coerce.number().default(0.75),
MARQS_AVAILABLE_CAPACITY_BIAS: z.coerce.number().default(0.3),
MARQS_QUEUE_AGE_RANDOMIZATION_BIAS: z.coerce.number().default(0.25),

PROD_TASK_HEARTBEAT_INTERVAL_MS: z.coerce.number().int().optional(),

Expand Down
Loading
Loading