Skip to content

Fix pre-pulling of deployment images onto worker nodes #1660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Fix pre-pulling of deployment images onto worker nodes #1660

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9b69d3
lint
nicktrn Feb 4, 2025
5494503
get pre-pull data from finalized deployment
nicktrn Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions apps/webapp/app/v3/services/finalizeDeployment.server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export class FinalizeDeploymentService extends BaseService {
data: {
status: "DEPLOYED",
deployedAt: new Date(),
imageReference: imageReference,
imageReference,
},
});

Expand Down Expand Up @@ -103,17 +103,17 @@ export class FinalizeDeploymentService extends BaseService {
logger.error("Failed to publish WORKER_CREATED event", { err });
}

if (deployment.imageReference) {
if (finalizedDeployment.imageReference) {
socketIo.providerNamespace.emit("PRE_PULL_DEPLOYMENT", {
version: "v1",
imageRef: deployment.imageReference,
shortCode: deployment.shortCode,
imageRef: finalizedDeployment.imageReference,
shortCode: finalizedDeployment.shortCode,
// identifiers
deploymentId: deployment.id,
deploymentId: finalizedDeployment.id,
envId: authenticatedEnv.id,
envType: authenticatedEnv.type,
orgId: authenticatedEnv.organizationId,
projectId: deployment.projectId,
projectId: finalizedDeployment.projectId,
});
}

Expand Down