- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 874
 
Icons: updates and new icons for the side menu, run page and general improvements to the way they work #1825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    Changes from 28 commits
      Commits
    
    
            Show all changes
          
          
            30 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      f1fe71e
              
                New format for the functions instead of “onWait() task”
              
              
                samejr 226ddfa
              
                Make the icon sizes match the hero icons
              
              
                samejr e93d9cb
              
                Updating icons for the new task hooks
              
              
                samejr d12c741
              
                Adds new icons to the RunIcon.tsx component
              
              
                samejr f63a87e
              
                Improves the size of the menu icons
              
              
                samejr 84684a3
              
                Fixes the missaligned environment dropdown and dev connected button
              
              
                samejr 6b5e31b
              
                Changes the button colours so they are all unique
              
              
                samejr 91efae8
              
                More icon updates
              
              
                samejr 3228ddd
              
                Adds new variables for main page icons
              
              
                samejr 1d62663
              
                Improves icons sizes
              
              
                samejr 6463cc6
              
                Using new color variables in the side menu and blank states
              
              
                samejr ce1b964
              
                Adds preview environment color variable
              
              
                samejr 9be5afb
              
                Align the env icon in the menu
              
              
                samejr 7694b3b
              
                Updates the env icons to be the correct size and padding to match her…
              
              
                samejr c14644a
              
                Label uses new colors, removes unused cases and new env icons
              
              
                samejr 0fd1336
              
                Lower case env label
              
              
                samejr 8d7c4a8
              
                Removes unused code
              
              
                samejr eaa5012
              
                Use full env title
              
              
                samejr 0af52c4
              
                Organize imports
              
              
                samejr 4f78d9c
              
                More variants of the runs icon to work at smaller sizes
              
              
                samejr 2346c42
              
                small padding adjustment
              
              
                samejr 14cadc6
              
                reformat init function span
              
              
                samejr b28feda
              
                Fix last init formatting
              
              
                samejr 121dae6
              
                New colour for settings
              
              
                samejr 5ff36c6
              
                Organize switch statement for icons nicely
              
              
                samejr 7ad2bf5
              
                Use new color variable
              
              
                samejr d179f8c
              
                Update icon svgs
              
              
                samejr d4a8e6d
              
                Merge remote-tracking branch 'origin/main' into icon-update
              
              
                samejr b1acd1a
              
                Renamed lifecycle hook icon to Function icon
              
              
                samejr da94d14
              
                Renamed function icon file name
              
              
                samejr File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -1,92 +1,153 @@ | ||
| export function DevEnvironmentIcon({ className }: { className?: string }) { | ||
| return ( | ||
| <svg className={className} viewBox="0 0 14 14" fill="none" xmlns="http://www.w3.org/2000/svg"> | ||
| <g clipPath="url(#clip0_15347_71059)"> | ||
| <circle cx="7" cy="7" r="2" fill="currentColor" /> | ||
| <path | ||
| d="M4.5 0.75H2.75C1.64543 0.75 0.75 1.64543 0.75 2.75V4.5" | ||
| stroke="currentColor" | ||
| strokeWidth="1.5" | ||
| strokeLinecap="round" | ||
| strokeLinejoin="round" | ||
| /> | ||
| <path | ||
| d="M13.25 4.5L13.25 2.75C13.25 1.64543 12.3546 0.75 11.25 0.75L9.5 0.75" | ||
| stroke="currentColor" | ||
| strokeWidth="1.5" | ||
| strokeLinecap="round" | ||
| strokeLinejoin="round" | ||
| /> | ||
| <path | ||
| d="M9.5 13.25L11.25 13.25C12.3546 13.25 13.25 12.3546 13.25 11.25L13.25 9.5" | ||
| stroke="currentColor" | ||
| strokeWidth="1.5" | ||
| strokeLinecap="round" | ||
| strokeLinejoin="round" | ||
| /> | ||
| <path | ||
| d="M0.75 9.5L0.75 11.25C0.75 12.3546 1.64543 13.25 2.75 13.25L4.5 13.25" | ||
| stroke="currentColor" | ||
| strokeWidth="1.5" | ||
| strokeLinecap="round" | ||
| strokeLinejoin="round" | ||
| /> | ||
| </g> | ||
| <defs> | ||
| <clipPath id="clip0_15347_71059"> | ||
| <rect width="14" height="14" fill="currentColor" /> | ||
| </clipPath> | ||
| </defs> | ||
| <svg className={className} viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg"> | ||
| <circle cx="12" cy="12" r="3" fill="currentColor" /> | ||
| <path | ||
| d="M8.35714 3H5C3.89543 3 3 3.89543 3 5V8.35714" | ||
| stroke="currentColor" | ||
| strokeWidth="2" | ||
| strokeLinecap="round" | ||
| strokeLinejoin="round" | ||
| /> | ||
| <path | ||
| d="M21 8.35714L21 5C21 3.89543 20.1046 3 19 3L15.6429 3" | ||
| stroke="currentColor" | ||
| strokeWidth="2" | ||
| strokeLinecap="round" | ||
| strokeLinejoin="round" | ||
| /> | ||
| <path | ||
| d="M15.6429 21L19 21C20.1046 21 21 20.1046 21 19L21 15.6429" | ||
| stroke="currentColor" | ||
| strokeWidth="2" | ||
| strokeLinecap="round" | ||
| strokeLinejoin="round" | ||
| /> | ||
| <path | ||
| d="M3 15.6429L3 19C3 20.1046 3.89543 21 5 21L8.35714 21" | ||
| stroke="currentColor" | ||
| strokeWidth="2" | ||
| strokeLinecap="round" | ||
| strokeLinejoin="round" | ||
| /> | ||
| </svg> | ||
| ); | ||
| } | ||
| 
     | 
||
| export function DevEnvironmentIconSmall({ className }: { className?: string }) { | ||
| return ( | ||
| <svg className={className} viewBox="0 0 20 20" fill="none" xmlns="http://www.w3.org/2000/svg"> | ||
| <circle cx="10" cy="10" r="2" fill="currentColor" /> | ||
| <path | ||
| d="M7 3H5C3.89543 3 3 3.89543 3 5V7" | ||
| stroke="currentColor" | ||
| strokeWidth="2" | ||
| strokeLinecap="round" | ||
| strokeLinejoin="round" | ||
| /> | ||
| <path | ||
| d="M17 7L17 5C17 3.89543 16.1046 3 15 3L13 3" | ||
| stroke="currentColor" | ||
| strokeWidth="2" | ||
| strokeLinecap="round" | ||
| strokeLinejoin="round" | ||
| /> | ||
| <path | ||
| d="M13 17L15 17C16.1046 17 17 16.1046 17 15L17 13" | ||
| stroke="currentColor" | ||
| strokeWidth="2" | ||
| strokeLinecap="round" | ||
| strokeLinejoin="round" | ||
| /> | ||
| <path | ||
| d="M3 13L3 15C3 16.1046 3.89543 17 5 17L7 17" | ||
| stroke="currentColor" | ||
| strokeWidth="2" | ||
| strokeLinecap="round" | ||
| strokeLinejoin="round" | ||
| /> | ||
| </svg> | ||
| ); | ||
| } | ||
| 
     | 
||
| export function ProdEnvironmentIcon({ className }: { className?: string }) { | ||
| return ( | ||
| <svg className={className} viewBox="0 0 14 14" fill="none" xmlns="http://www.w3.org/2000/svg"> | ||
| <svg className={className} viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg"> | ||
| <path | ||
| d="M12.5037 7.33603C12.3174 6.88799 11.6827 6.88799 11.4963 7.33603L10.4338 9.89064L7.6759 10.1117C7.1922 10.1505 6.99606 10.7542 7.36459 11.0698L9.46583 12.8698L8.82387 15.561C8.71128 16.033 9.22477 16.4061 9.63888 16.1532L12 14.711L14.3612 16.1532C14.7753 16.4061 15.2888 16.0331 15.1762 15.561L14.5343 12.8698L16.6355 11.0698C17.004 10.7542 16.8079 10.1505 16.3242 10.1117L13.5663 9.89064L12.5037 7.33603Z" | ||
| fill="white" | ||
| /> | ||
| <rect | ||
| x="0.75" | ||
| y="0.75" | ||
| width="12.5" | ||
| height="12.5" | ||
| rx="3.25" | ||
| x="3" | ||
| y="3" | ||
| width="18" | ||
| height="18" | ||
| rx="2" | ||
| stroke="currentColor" | ||
| strokeWidth="1.5" | ||
| strokeWidth="2" | ||
| strokeLinecap="round" | ||
| strokeLinejoin="round" | ||
| /> | ||
| <g clipPath="url(#clip0_15515_83281)"> | ||
| <path | ||
| fillRule="evenodd" | ||
| clipRule="evenodd" | ||
| d="M7.34731 4.15348C7.21887 3.84467 6.78141 3.84467 6.65298 4.15348L5.92066 5.91419L4.01982 6.06658C3.68644 6.0933 3.55126 6.50935 3.80526 6.72693L5.2535 7.96749L4.81104 9.82238C4.73344 10.1477 5.08735 10.4048 5.37277 10.2305L7.00014 9.23651L8.62752 10.2305C8.91294 10.4048 9.26685 10.1477 9.18925 9.82238L8.74679 7.96749L10.195 6.72693C10.449 6.50935 10.3138 6.0933 9.98046 6.06658L8.07963 5.91419L7.34731 4.15348Z" | ||
| fill="currentColor" | ||
| /> | ||
| </g> | ||
| <defs> | ||
| <clipPath id="clip0_15515_83281"> | ||
| <rect width="8" height="8" fill="currentColor" transform="translate(3 3)" /> | ||
| </clipPath> | ||
| </defs> | ||
| </svg> | ||
| ); | ||
| } | ||
| 
     | 
||
| export function ProdEnvironmentIconSmall({ className }: { className?: string }) { | ||
| return ( | ||
| <svg className={className} viewBox="0 0 20 20" fill="none" xmlns="http://www.w3.org/2000/svg"> | ||
| <rect | ||
| x="3" | ||
| y="3" | ||
| width="14" | ||
| height="14" | ||
| rx="3" | ||
| stroke="currentColor" | ||
| strokeWidth="2" | ||
| strokeLinecap="round" | ||
| strokeLinejoin="round" | ||
| /> | ||
| <path | ||
| d="M10.4174 6.23514C10.263 5.86384 9.73701 5.86384 9.58258 6.23514L8.70207 8.35213L6.4166 8.53536C6.01575 8.56749 5.85322 9.06773 6.15862 9.32934L7.89991 10.8209L7.36792 13.0512C7.27461 13.4423 7.70014 13.7515 8.04332 13.5419L10 12.3467L11.9567 13.5419C12.2999 13.7515 12.7254 13.4423 12.6321 13.0512L12.1001 10.8209L13.8414 9.32934C14.1468 9.06773 13.9842 8.56749 13.5834 8.53536L11.2979 8.35213L10.4174 6.23514Z" | ||
| fill="currentColor" | ||
| /> | ||
| </svg> | ||
| ); | ||
| } | ||
| 
     | 
||
| export function DeployedEnvironmentIcon({ className }: { className?: string }) { | ||
| return ( | ||
| <svg className={className} viewBox="0 0 14 14" fill="none" xmlns="http://www.w3.org/2000/svg"> | ||
| <svg className={className} viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg"> | ||
| <circle cx="12" cy="12" r="3" fill="currentColor" /> | ||
| <rect | ||
| x="3" | ||
| y="3" | ||
| width="18" | ||
| height="18" | ||
| rx="2" | ||
| stroke="currentColor" | ||
| strokeWidth="2" | ||
| strokeLinecap="round" | ||
| strokeLinejoin="round" | ||
| /> | ||
| </svg> | ||
| ); | ||
| } | ||
| 
     | 
||
| export function DeployedEnvironmentIconSmall({ className }: { className?: string }) { | ||
| return ( | ||
| <svg className={className} viewBox="0 0 20 20" fill="none" xmlns="http://www.w3.org/2000/svg"> | ||
| <circle cx="10" cy="10" r="2" fill="currentColor" /> | ||
| <rect | ||
| x="0.75" | ||
| y="0.75" | ||
| width="12.5" | ||
| height="12.5" | ||
| rx="3.25" | ||
| x="3" | ||
| y="3" | ||
| width="14" | ||
| height="14" | ||
| rx="3" | ||
| stroke="currentColor" | ||
| strokeWidth="1.5" | ||
| strokeWidth="2" | ||
| strokeLinecap="round" | ||
| strokeLinejoin="round" | ||
| /> | ||
| <circle cx="7" cy="7" r="2" fill="currentColor" /> | ||
| </svg> | ||
| ); | ||
| } | ||
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| export function MiddlewareIcon({ className }: { className?: string }) { | ||
| return ( | ||
| <svg className={className} viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg"> | ||
| <rect | ||
| x="2.5" | ||
| y="2.5" | ||
| width="19" | ||
| height="19" | ||
| rx="2.5" | ||
| stroke="currentColor" | ||
| strokeOpacity={0.5} | ||
| /> | ||
| <path | ||
| fillRule="evenodd" | ||
| clipRule="evenodd" | ||
| d="M8.72775 14.8717V11.1087C8.72775 10.4761 9.24051 9.96338 9.87303 9.96338C10.5056 9.96338 11.0183 10.4761 11.0183 11.1087V15.5262V16.5079H12.9817V15.5262V11.1087C12.9817 10.4761 13.4944 9.96334 14.1269 9.96334C14.7594 9.96334 15.2722 10.4761 15.2722 11.1086V15.5262V16.5079H17.2356V15.5262V11.1086C17.2356 9.39177 15.8438 8 14.1269 8C13.3041 8 12.556 8.31966 12 8.84155C11.4439 8.31968 10.6958 8.00004 9.87303 8.00004C9.46858 8.00004 9.08217 8.07728 8.72775 8.21781V8.00004H6.7644V8.98171V11.1087V14.8717V15.5262V15.8534V16.5079H8.72775V15.8534V15.5262V14.8717Z" | ||
| fill="currentColor" | ||
| /> | ||
| </svg> | ||
| ); | ||
| } | 
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| export function RunFunctionIcon({ className }: { className?: string }) { | ||
| return ( | ||
| <svg className={className} viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg"> | ||
| <rect | ||
| x="2.5" | ||
| y="2.5" | ||
| width="19" | ||
| height="19" | ||
| rx="2.5" | ||
| stroke="currentColor" | ||
| strokeOpacity={0.5} | ||
| /> | ||
| <path | ||
| fillRule="evenodd" | ||
| clipRule="evenodd" | ||
| d="M12 8H10V12V16.5159H12V12C12 10.8954 12.8954 10 14 10H15.5V8H14C13.2714 8 12.5883 8.19479 12 8.53513V8Z" | ||
| fill="currentColor" | ||
| /> | ||
| </svg> | ||
| ); | ||
| } | 
      
      Oops, something went wrong.
        
    
  
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix inconsistent fill color in ProdEnvironmentIcon
The star path in ProdEnvironmentIcon uses a hardcoded white fill, while the small variant uses currentColor. This inconsistency could cause issues in dark themes or when custom colors are applied.
📝 Committable suggestion