Skip to content

Max duration error referenced ms when it should seconds #1848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025
Merged

Max duration error referenced ms when it should seconds #1848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/v3/workers/taskExecutor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ export class TaskExecutor {
reject(
new InternalError({
code: TaskRunErrorCodes.MAX_DURATION_EXCEEDED,
message: `Task execution exceeded maximum duration of ${maxDuration}ms`,
message: `Run exceeded maximum compute time (maxDuration) of ${maxDuration} seconds`,
})
);
});
Expand Down
6 changes: 3 additions & 3 deletions packages/core/test/taskExecutor.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1417,7 +1417,7 @@ describe("TaskExecutor", () => {

test("should handle max duration abort signal and call hooks in correct order", async () => {
const executionOrder: string[] = [];
const maxDurationMs = 1000;
const maxDurationSeconds = 1000;

// Create an abort controller that we'll trigger manually
const controller = new AbortController();
Expand All @@ -1439,7 +1439,7 @@ describe("TaskExecutor", () => {
fn: async ({ error }) => {
executionOrder.push("failure");
expect((error as Error).message).toBe(
`Task execution exceeded maximum duration of ${maxDurationMs}ms`
`Run exceeded maximum compute time (maxDuration) of ${maxDurationSeconds} seconds`
);
},
});
Expand Down Expand Up @@ -1494,7 +1494,7 @@ describe("TaskExecutor", () => {
error: {
type: "INTERNAL_ERROR",
code: TaskRunErrorCodes.MAX_DURATION_EXCEEDED,
message: "Task execution exceeded maximum duration of 1000ms",
message: "Run exceeded maximum compute time (maxDuration) of 1000 seconds",
stackTrace: expect.any(String),
},
skippedRetrying: false,
Expand Down