Only include v4 debug logs for admins

[nicktrn]

We added excessive debug logs for the v4-beta to help us more quickly identify and fix any issues. When you click the "download logs" button they shouldn't be included.

Summary by CodeRabbit

• New Features
  • Enhanced user authentication to improve retrieval of user information.
  • Introduced refined log access control: non-admin users will no longer see sensitive debug logs, ensuring that detailed log events remain exclusive to administrators.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 283d4ea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

The update modifies the log download route by changing the way user information is retrieved. The code now uses a more detailed user object by replacing requireUserId with requireUser, accessing the user’s ID via user.id. A conditional check has been added to filter out log events (specifically those of type TaskEventKind.LOG) for non-admin users, enhancing access control over log visibility.

Changes

File Path	Change Summary
apps/webapp/.../resources.runs.$runParam.logs.download.ts	- Updated import from requireUserId to requireUser - Changed variable from userId to user with access via user.id - Added conditional to filter out debug log events for non-admin users

Sequence Diagram(s)

sequenceDiagram
    participant Client as Client Request
    participant Loader as Log Loader
    participant Auth as Authentication Service

    Client->>Loader: HTTP Request
    Loader->>Auth: requireUser(request)
    Auth-->>Loader: Return user object (with user.id, admin flag)
    Loader->>Loader: Check if event.kind === TaskEventKind.LOG
    Loader->>Loader: Evaluate if user.admin is false
    alt Non-admin user and LOG event
        Loader-->>Client: Skip processing event
    else
        Loader-->>Client: Process and stream log event
    end

Loading

Poem

In a field of code so deep and wide,
I, the rabbit, take a joyful stride.
User details now are clear and bright,
Admin checks keep logs in sight.
With each hop, improvements bloom anew—
A code garden where dreams come true!
🐇✨

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)

• We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 030c8ae and 283d4ea.

📒 Files selected for processing (1)

• apps/webapp/app/routes/resources.runs.$runParam.logs.download.ts (3 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

apps/webapp/app/routes/resources.runs.$runParam.logs.download.ts (2)

apps/webapp/app/routes/resources.runs.$runParam.ts (1)

• loader (13-227)

apps/webapp/app/services/session.server.ts (1)

• requireUser (39-61)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: typecheck / typecheck
• GitHub Check: Analyze (javascript-typescript)

🔇 Additional comments (3)

apps/webapp/app/routes/resources.runs.$runParam.logs.download.ts (3)

3-3: Good change to get the full user object

This change appropriately switches from just retrieving the user ID to getting the complete user object, which is necessary for checking admin status. The implementation correctly maintains the existing authorization flow while providing access to additional user properties.

Also applies to: 14-14, 24-24

---

11-11: Appropriate import for the new filtering logic

The import of TaskEventKind is correctly added to support the new filtering logic for debug logs.

---

48-51: Well-implemented filtering of debug logs for non-admin users

This implementation perfectly aligns with the PR objective to exclude v4 debug logs for non-admin users when they download logs. The conditional check is clear, efficient, and has a helpful comment explaining its purpose. This is a good security enhancement that ensures sensitive debug information is only available to administrators.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.