Skip to content

Changes button spinner to white and Replay Run button changes to secondary variant #1912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2025
Merged

Changes button spinner to white and Replay Run button changes to secondary variant #1912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb4c09f
Uses the white variant of the spinner instead of dark on the replay r…
samejr Apr 11, 2025
2109d73
Changes the replay run button on the run page to secondary
samejr Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/webapp/app/components/runs/v3/ReplayRunDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { InputGroup } from "~/components/primitives/InputGroup";
import { Label } from "~/components/primitives/Label";
import { Paragraph } from "~/components/primitives/Paragraph";
import { Select, SelectItem } from "~/components/primitives/Select";
import { ButtonSpinner, Spinner } from "~/components/primitives/Spinner";
import { Spinner, SpinnerWhite } from "~/components/primitives/Spinner";
import { type loader } from "~/routes/resources.taskruns.$runParam.replay";

type ReplayRunDialogProps = {
Expand Down Expand Up @@ -157,7 +157,7 @@ function ReplayForm({
<Button
type="submit"
variant="primary/medium"
LeadingIcon={isSubmitting ? ButtonSpinner : undefined}
LeadingIcon={isSubmitting ? SpinnerWhite : undefined}
disabled={isSubmitting}
shortcut={{ modifiers: ["mod"], key: "enter", enabledOnInputElements: true }}
>
Expand Down
3 changes: 2 additions & 1 deletion ..._app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.runs.$runParam/route.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,9 +224,10 @@ export default function Page() {
<Dialog key={`replay-${run.friendlyId}`}>
<DialogTrigger asChild>
<Button
variant="tertiary/small"
variant="secondary/small"
LeadingIcon={ArrowUturnLeftIcon}
shortcut={{ key: "R" }}
className="pr-2"
>
Replay run
</Button>
Expand Down