-
-
Notifications
You must be signed in to change notification settings - Fork 853
Add missing dependency to supervisor Containerfile #1959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing dependency to supervisor Containerfile #1959
Conversation
Without the `docker` package being installed, the supervisor is unable to start runs when deployed on a Docker platform. Signed-off-by: Erin Allison <[email protected]>
|
WalkthroughThe Dockerfile for the supervisor application was updated to install the docker CLI tool in addition to dumb-init during the base image setup. This modification ensures that the docker command-line utility is available within the container at runtime. No other build steps, environment variables, or commands were altered. Changes
Poem
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms (5)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Hey @erin-allison thanks for this but I'll close this for now. There's a few more things to change for the self-hosting setup and we most likely won't need the docker package once that's done. If we did include it, the image size would go from 307MB to 574MB. More details on Discord. |
Without the
docker
package being installed, the supervisor is unable to start runs when deployed on a Docker platform.✅ Checklist
Testing
Added docker on top of the published image and confirmed it starts runs.
https://canary.discord.com/channels/1066956501299777596/1363644206089769142/1363644207717154978
Summary by CodeRabbit