Skip to content

[v4] Fix for completing batches (when there are idempotent runs) #1985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025
Merged

[v4] Fix for completing batches (when there are idempotent runs) #1985

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions apps/webapp/app/runEngine/services/batchTrigger.server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,20 +564,27 @@ export class RunEngineBatchTriggerService extends WithRunEngine {
runIds: {
push: runIds,
},
processingJobsCount: {
increment: runIds.length,
},
},
select: {
processingJobsCount: true,
runCount: true,
},
});

// if there are more items to process, requeue the batch
if (workingIndex < batch.runCount) {
return { status: "INCOMPLETE", workingIndex };
}

//triggered all the runs
if (updatedBatch.runIds.length === updatedBatch.runCount) {
if (updatedBatch.processingJobsCount >= updatedBatch.runCount) {
//if all the runs were idempotent, it's possible the batch is already completed
await this._engine.tryCompleteBatch({ batchId: batch.id });
}

// if there are more items to process, requeue the batch
if (workingIndex < batch.runCount) {
return { status: "INCOMPLETE", workingIndex };
}

return { status: "COMPLETE" };
}

Expand Down