Add @trigger.dev/test package #2072

devin-ai-integration · 2025-05-18T19:15:32Z

Add @trigger.dev/test package

This PR adds a new public package called @trigger.dev/test that allows users to easily test their trigger.dev tasks and works well with testing frameworks.

Features

Mock task creation and execution
Unit testing tasks with mocked dependencies
Verification of task triggers
Testing of task hooks
Integration with testing frameworks like vitest

Implementation

The package provides utilities for:

Creating mock tasks
Mocking task dependencies for unit testing
Verifying task execution
Testing task hooks
Mocking task triggers

Build Notes

There are some build issues related to missing dependencies in the core package (@trigger.dev/database). These issues are not directly related to the test package implementation but affect the build process. The package structure and implementation are complete and follow the patterns of other trigger.dev packages.

Link to Devin run: https://app.devin.ai/sessions/858a1bf6d356405c995149189721f73b
Requested by: Eric Allam ([email protected])

Co-Authored-By: Eric Allam <[email protected]>

devin-ai-integration · 2025-05-18T19:15:38Z

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

Disable automatic comment and CI monitoring

coderabbitai · 2025-05-18T19:15:39Z

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

packages/test/src/mockHooks.ts

+
+    const hookCallInfo = this.hookCalls[taskId];
+
+    hookCallInfo[hookType] = true;


To fix the issue, we need to ensure that taskId cannot be a value like __proto__, constructor, or prototype that could lead to prototype pollution. This can be achieved by validating taskId before using it as a key in the hookCalls object. If taskId contains any of these reserved values, the method should throw an error or handle the case appropriately.

The best approach is to add a validation step at the beginning of the recordHookCall method to check if taskId is one of the reserved keys. If it is, the method should throw an error or return early without making any changes.

Co-Authored-By: Eric Allam <[email protected]>

changeset-bot · 2025-05-18T19:21:24Z

⚠️ No Changeset found

Latest commit: 51124a5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Add @trigger.dev/test package for testing trigger.dev tasks

c7fe3f4

Co-Authored-By: Eric Allam <[email protected]>

github-advanced-security bot found potential problems May 18, 2025

View reviewed changes

Update pnpm-lock.yaml for @trigger.dev/test package

51124a5

Co-Authored-By: Eric Allam <[email protected]>

ericallam closed this May 18, 2025

@@ -19,2 +19,7 @@
               ) {
+                // Validate taskId to prevent prototype pollution
+                if (["__proto__", "constructor", "prototype"].includes(taskId)) {
+                  throw new Error(`Invalid taskId: "${taskId}" is a reserved key.`);
+                }
                 if (!this.hookCalls[taskId]) {

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Add @trigger.dev/test package #2072

Add @trigger.dev/test package #2072

Uh oh!

devin-ai-integration bot commented May 18, 2025

Uh oh!

devin-ai-integration bot commented May 18, 2025

Uh oh!

coderabbitai bot commented May 18, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Check warning

Copilot Autofix

changeset-bot bot commented May 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant


		const hookCallInfo = this.hookCalls[taskId];

		hookCallInfo[hookType] = true;

Uh oh!

Add @trigger.dev/test package #2072

Add @trigger.dev/test package #2072

Uh oh!

Conversation

devin-ai-integration bot commented May 18, 2025

Add @trigger.dev/test package

Features

Implementation

Build Notes

Uh oh!

devin-ai-integration bot commented May 18, 2025

🤖 Devin AI Engineer

Uh oh!

coderabbitai bot commented May 18, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Check warning

Uh oh!

Copilot Autofix

changeset-bot bot commented May 18, 2025

⚠️ No Changeset found

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

CodeRabbit Configuration File (`.coderabbit.yaml`)