Skip to content

Fix update command version detection #2199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 27, 2025
Merged

Fix update command version detection #2199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68a4026
fix root package.json resolution
nicktrn Jun 25, 2025
f9a8bd4
add changeset
nicktrn Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/chilled-weeks-switch.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"trigger.dev": patch
---

Fix update command version mismatch detection
22 changes: 17 additions & 5 deletions packages/cli-v3/src/commands/update.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { confirm, intro, isCancel, log, outro } from "@clack/prompts";
import { Command } from "commander";
import { detectPackageManager, installDependencies } from "nypm";
import { basename, dirname, resolve } from "path";
import { PackageJson, readPackageJSON, resolvePackageJSON } from "pkg-types";
import { PackageJson, readPackageJSON, type ResolveOptions, resolvePackageJSON } from "pkg-types";
import { z } from "zod";
import { CommonCommandOptions, OutroCommandError, wrapCommandAction } from "../cli/common.js";
import { chalkError, prettyError, prettyWarning } from "../utilities/cliOutput.js";
Expand Down Expand Up @@ -339,8 +339,20 @@ async function tryResolveTriggerPackageVersion(

logger.debug(`Resolved ${name} package version path`, { name, resolvedPath });

// IMPORTANT: keep the two dirname calls, as the first one resolves the nested package.json inside dist/commonjs or dist/esm
const { packageJson } = await getPackageJson(dirname(dirname(resolvedPath)));
const { packageJson } = await getPackageJson(dirname(resolvedPath), {
test: (filePath) => {
// We need to skip any type-marker files
if (filePath.includes("dist/commonjs")) {
return false;
}

if (filePath.includes("dist/esm")) {
return false;
}

return true;
},
});

if (packageJson.version) {
logger.debug(`Resolved ${name} package version`, { name, version: packageJson.version });
Expand Down Expand Up @@ -398,8 +410,8 @@ async function updateConfirmation(depsToUpdate: Dependency[], targetVersion: str
});
}

export async function getPackageJson(absoluteProjectPath: string) {
const packageJsonPath = await resolvePackageJSON(absoluteProjectPath);
export async function getPackageJson(absoluteProjectPath: string, options?: ResolveOptions) {
const packageJsonPath = await resolvePackageJSON(absoluteProjectPath, options);
const readonlyPackageJson = await readPackageJSON(packageJsonPath);

const packageJson = structuredClone(readonlyPackageJson);
Expand Down