Skip to content

feat: enable overriding run options when replaying #2260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 11, 2025
Merged

feat: enable overriding run options when replaying #2260

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
7c03409
Rearrange the layout of the replay modal
myftija Jul 10, 2025
49ee049
Add run options to the replay modal
myftija Jul 10, 2025
cfd8556
Handle payload and metadata correctly in the shared json editor
myftija Jul 10, 2025
c8958ac
Apply run options in replays
myftija Jul 11, 2025
a4b2233
Fix clear button issue in json editor
myftija Jul 11, 2025
2ab138e
Update replay modal hint
myftija Jul 11, 2025
e923081
Move machine and version fields to the top for visibility
myftija Jul 11, 2025
e0bb5cb
Use the same field ordering in the test page
myftija Jul 11, 2025
21dda1a
Reload queues and versions on env override
myftija Jul 11, 2025
92b6db3
Adapt json editor to fill full height
myftija Jul 11, 2025
0719def
Clean up a few excessive ternaries
myftija Jul 11, 2025
d70a429
Avoid ui jump on env selection
myftija Jul 11, 2025
d44269b
Switch to sexy scrollbars for scheduled tasks in the test page
myftija Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/webapp/app/components/code/JSONEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,13 +125,13 @@ export function JSONEditor(opts: JSONEditorProps) {
}
}, [defaultValue, view]);

const clear = useCallback(() => {
const clear = () => {
if (view === undefined) return;
view.dispatch({
changes: { from: 0, to: view.state.doc.length, insert: undefined },
});
onChange?.("");
}, [view]);
};

const copy = useCallback(() => {
if (view === undefined) return;
Expand Down
Loading