Skip to content

fix: prevent large root/parent metadata updates from endlessly retrying #2290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericallam merged 4 commits into from
Jul 21, 2025
Merged

fix: prevent large root/parent metadata updates from endlessly retrying #2290

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3cfa5c9
fixing metadata WIP
ericallam Jul 21, 2025
54a211e
WIP
ericallam Jul 21, 2025
de109fb
fix: prevent large root/parent metadata updates from endlessly retrying
ericallam Jul 21, 2025
77fd606
Fixed other calls to handleMetadataPacket
ericallam Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/webapp/app/routes/api.v1.runs.$runId.metadata.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ import { json } from "@remix-run/server-runtime";
import { tryCatch } from "@trigger.dev/core/utils";
import { UpdateMetadataRequestBody } from "@trigger.dev/core/v3";
import { z } from "zod";
import { updateMetadataService } from "~/services/metadata/updateMetadata.server";
import { updateMetadataService } from "~/services/metadata/updateMetadataInstance.server";
import { createActionApiRoute } from "~/services/routeBuilders/apiBuilder.server";
import { ServiceValidationError } from "~/v3/services/baseService.server";
import { ServiceValidationError } from "~/v3/services/common.server";

const ParamsSchema = z.object({
runId: z.string(),
Expand Down
6 changes: 5 additions & 1 deletion apps/webapp/app/runEngine/services/triggerTask.server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ export class RunEngineTriggerTaskService {
private readonly engine: RunEngine;
private readonly tracer: Tracer;
private readonly traceEventConcern: TraceEventConcern;
private readonly metadataMaximumSize: number;

constructor(opts: {
prisma: PrismaClientOrTransaction;
Expand All @@ -57,6 +58,7 @@ export class RunEngineTriggerTaskService {
runNumberIncrementer: RunNumberIncrementer;
traceEventConcern: TraceEventConcern;
tracer: Tracer;
metadataMaximumSize: number;
}) {
this.prisma = opts.prisma;
this.engine = opts.engine;
Expand All @@ -67,6 +69,7 @@ export class RunEngineTriggerTaskService {
this.runNumberIncrementer = opts.runNumberIncrementer;
this.tracer = opts.tracer;
this.traceEventConcern = opts.traceEventConcern;
this.metadataMaximumSize = opts.metadataMaximumSize;
}

public async call({
Expand Down Expand Up @@ -188,7 +191,8 @@ export class RunEngineTriggerTaskService {
const metadataPacket = body.options?.metadata
? handleMetadataPacket(
body.options?.metadata,
body.options?.metadataType ?? "application/json"
body.options?.metadataType ?? "application/json",
this.metadataMaximumSize
)
: undefined;

Expand Down
Loading
Loading