The schedule HTTP API now accepts deduplicationKeys as well as schedule IDs in the URL #2329
Conversation
…le IDs in the URL
WalkthroughA new module was introduced to centralize the logic for generating Prisma query filter objects for task schedules, based on project and schedule identifiers. Two functions, Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
apps/webapp/app/routes/api.v1.schedules.$scheduleId.activate.ts (1)
14-17: Return a proper JSONResponsefor the 405 branch
Returning a plain object ({ status: 405, body: … }) differs from every other branch that usesjson(), so callers receive inconsistent response shapes / headers.- if (request.method.toUpperCase() !== "POST") { - return { status: 405, body: "Method Not Allowed" }; + if (request.method.toUpperCase() !== "POST") { + return json({ error: "Method Not Allowed" }, { status: 405 }); }
🧹 Nitpick comments (2)
apps/webapp/app/routes/api.v1.schedules.$scheduleId.activate.ts (2)
35-41: PreferfindUnique+scheduleUniqWhereClauseto avoid a full scan
findFirstperforms a filter;findUniqueleverages the unique index and is both faster and clearer, given the clause is already unique.- const existingSchedule = await prisma.taskSchedule.findFirst({ - where: scheduleWhereClause( - authenticationResult.environment.projectId, - parsedParams.data.scheduleId - ), - }); + const uniqWhere = scheduleUniqWhereClause( + authenticationResult.environment.projectId, + parsedParams.data.scheduleId + ); + + const existingSchedule = await prisma.taskSchedule.findUnique({ + where: uniqWhere, + });
48-52: Reuse the sameuniqWherefor the update to remove duplication- await prisma.taskSchedule.update({ - where: scheduleUniqWhereClause( - authenticationResult.environment.projectId, - parsedParams.data.scheduleId - ), + await prisma.taskSchedule.update({ + where: uniqWhere, data: { active: true, }, });
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
apps/webapp/app/models/schedules.server.ts(1 hunks)apps/webapp/app/presenters/v3/ViewSchedulePresenter.server.ts(2 hunks)apps/webapp/app/routes/api.v1.schedules.$scheduleId.activate.ts(2 hunks)apps/webapp/app/routes/api.v1.schedules.$scheduleId.deactivate.ts(2 hunks)apps/webapp/app/routes/api.v1.schedules.$scheduleId.ts(2 hunks)apps/webapp/app/v3/services/upsertTaskSchedule.server.ts(2 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{ts,tsx}
📄 CodeRabbit Inference Engine (.github/copilot-instructions.md)
**/*.{ts,tsx}: Always prefer using isomorphic code like fetch, ReadableStream, etc. instead of Node.js specific code
For TypeScript, we usually use types over interfaces
Avoid enums
No default exports, use function declarations
Files:
apps/webapp/app/routes/api.v1.schedules.$scheduleId.deactivate.tsapps/webapp/app/routes/api.v1.schedules.$scheduleId.tsapps/webapp/app/routes/api.v1.schedules.$scheduleId.activate.tsapps/webapp/app/v3/services/upsertTaskSchedule.server.tsapps/webapp/app/presenters/v3/ViewSchedulePresenter.server.tsapps/webapp/app/models/schedules.server.ts
{packages/core,apps/webapp}/**/*.{ts,tsx}
📄 CodeRabbit Inference Engine (.github/copilot-instructions.md)
We use zod a lot in packages/core and in the webapp
Files:
apps/webapp/app/routes/api.v1.schedules.$scheduleId.deactivate.tsapps/webapp/app/routes/api.v1.schedules.$scheduleId.tsapps/webapp/app/routes/api.v1.schedules.$scheduleId.activate.tsapps/webapp/app/v3/services/upsertTaskSchedule.server.tsapps/webapp/app/presenters/v3/ViewSchedulePresenter.server.tsapps/webapp/app/models/schedules.server.ts
apps/webapp/**/*.{ts,tsx}
📄 CodeRabbit Inference Engine (.cursor/rules/webapp.mdc)
apps/webapp/**/*.{ts,tsx}: In the webapp, all environment variables must be accessed through theenvexport ofenv.server.ts, instead of directly accessingprocess.env.
When importing from@trigger.dev/corein the webapp, never import from the root@trigger.dev/corepath; always use one of the subpath exports as defined in the package's package.json.
Files:
apps/webapp/app/routes/api.v1.schedules.$scheduleId.deactivate.tsapps/webapp/app/routes/api.v1.schedules.$scheduleId.tsapps/webapp/app/routes/api.v1.schedules.$scheduleId.activate.tsapps/webapp/app/v3/services/upsertTaskSchedule.server.tsapps/webapp/app/presenters/v3/ViewSchedulePresenter.server.tsapps/webapp/app/models/schedules.server.ts
🧠 Learnings (17)
📓 Common learnings
Learnt from: CR
PR: triggerdotdev/trigger.dev#0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-07-18T17:50:25.014Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : When using idempotency, use the `idempotencyKeys` API and `idempotencyKey`/`idempotencyKeyTTL` options as shown.
Learnt from: CR
PR: triggerdotdev/trigger.dev#0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-07-18T17:50:25.014Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : When implementing scheduled (cron) tasks, use `schedules.task` from `@trigger.dev/sdk/v3` and follow the shown patterns.
📚 Learning: applies to **/trigger/**/*.{ts,tsx,js,jsx} : when implementing scheduled (cron) tasks, use `schedule...
Learnt from: CR
PR: triggerdotdev/trigger.dev#0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-07-18T17:50:25.014Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : When implementing scheduled (cron) tasks, use `schedules.task` from `@trigger.dev/sdk/v3` and follow the shown patterns.
Applied to files:
apps/webapp/app/routes/api.v1.schedules.$scheduleId.deactivate.tsapps/webapp/app/routes/api.v1.schedules.$scheduleId.tsapps/webapp/app/routes/api.v1.schedules.$scheduleId.activate.tsapps/webapp/app/v3/services/upsertTaskSchedule.server.tsapps/webapp/app/presenters/v3/ViewSchedulePresenter.server.tsapps/webapp/app/models/schedules.server.ts
📚 Learning: applies to {packages/core,apps/webapp}/**/*.{ts,tsx} : we use zod a lot in packages/core and in the ...
Learnt from: CR
PR: triggerdotdev/trigger.dev#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-07-18T17:49:24.468Z
Learning: Applies to {packages/core,apps/webapp}/**/*.{ts,tsx} : We use zod a lot in packages/core and in the webapp
Applied to files:
apps/webapp/app/routes/api.v1.schedules.$scheduleId.deactivate.tsapps/webapp/app/routes/api.v1.schedules.$scheduleId.tsapps/webapp/app/routes/api.v1.schedules.$scheduleId.activate.ts
📚 Learning: applies to internal-packages/database/**/*.{ts,tsx} : we use prisma in internal-packages/database fo...
Learnt from: CR
PR: triggerdotdev/trigger.dev#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-07-18T17:49:24.468Z
Learning: Applies to internal-packages/database/**/*.{ts,tsx} : We use prisma in internal-packages/database for our database interactions using PostgreSQL
Applied to files:
apps/webapp/app/routes/api.v1.schedules.$scheduleId.deactivate.tsapps/webapp/app/routes/api.v1.schedules.$scheduleId.tsapps/webapp/app/routes/api.v1.schedules.$scheduleId.activate.tsapps/webapp/app/v3/services/upsertTaskSchedule.server.tsapps/webapp/app/presenters/v3/ViewSchedulePresenter.server.tsapps/webapp/app/models/schedules.server.ts
📚 Learning: applies to apps/webapp/app/v3/presenters/**/*.server.ts : favor the use of 'presenters' to move comp...
Learnt from: CR
PR: triggerdotdev/trigger.dev#0
File: .cursor/rules/webapp.mdc:0-0
Timestamp: 2025-07-18T17:49:47.180Z
Learning: Applies to apps/webapp/app/v3/presenters/**/*.server.ts : Favor the use of 'presenters' to move complex loader code into a class, as seen in `app/v3/presenters/**/*.server.ts`.
Applied to files:
apps/webapp/app/routes/api.v1.schedules.$scheduleId.deactivate.tsapps/webapp/app/routes/api.v1.schedules.$scheduleId.activate.tsapps/webapp/app/presenters/v3/ViewSchedulePresenter.server.tsapps/webapp/app/models/schedules.server.ts
📚 Learning: in apps/webapp/app/services/runsrepository.server.ts, the in-memory status filtering after fetching ...
Learnt from: matt-aitken
PR: triggerdotdev/trigger.dev#2264
File: apps/webapp/app/services/runsRepository.server.ts:172-174
Timestamp: 2025-07-12T18:06:04.133Z
Learning: In apps/webapp/app/services/runsRepository.server.ts, the in-memory status filtering after fetching runs from Prisma is intentionally used as a workaround for ClickHouse data delays. This approach is acceptable because the result set is limited to a maximum of 100 runs due to pagination, making the performance impact negligible.
Applied to files:
apps/webapp/app/routes/api.v1.schedules.$scheduleId.deactivate.tsapps/webapp/app/routes/api.v1.schedules.$scheduleId.activate.tsapps/webapp/app/v3/services/upsertTaskSchedule.server.tsapps/webapp/app/presenters/v3/ViewSchedulePresenter.server.tsapps/webapp/app/models/schedules.server.ts
📚 Learning: applies to **/trigger/**/*.{ts,tsx,js,jsx} : when implementing schema tasks, use `schematask` from `...
Learnt from: CR
PR: triggerdotdev/trigger.dev#0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-07-18T17:50:25.014Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : When implementing schema tasks, use `schemaTask` from `@trigger.dev/sdk/v3` and validate payloads as shown.
Applied to files:
apps/webapp/app/routes/api.v1.schedules.$scheduleId.tsapps/webapp/app/v3/services/upsertTaskSchedule.server.tsapps/webapp/app/models/schedules.server.ts
📚 Learning: applies to **/trigger/**/*.{ts,tsx,js,jsx} : you must use `@trigger.dev/sdk/v3` when writing trigger...
Learnt from: CR
PR: triggerdotdev/trigger.dev#0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-07-18T17:50:25.014Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : You MUST use `@trigger.dev/sdk/v3` when writing Trigger.dev tasks.
Applied to files:
apps/webapp/app/routes/api.v1.schedules.$scheduleId.ts
📚 Learning: applies to **/trigger/**/*.{ts,tsx,js,jsx} : when triggering a task from backend code, use `tasks.tr...
Learnt from: CR
PR: triggerdotdev/trigger.dev#0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-07-18T17:50:25.014Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : When triggering a task from backend code, use `tasks.trigger`, `tasks.batchTrigger`, or `tasks.triggerAndPoll` as shown in the examples.
Applied to files:
apps/webapp/app/routes/api.v1.schedules.$scheduleId.tsapps/webapp/app/routes/api.v1.schedules.$scheduleId.activate.ts
📚 Learning: applies to **/trigger/**/*.{ts,tsx,js,jsx} : always generate trigger.dev tasks using the `task` func...
Learnt from: CR
PR: triggerdotdev/trigger.dev#0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-07-18T17:50:25.014Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : ALWAYS generate Trigger.dev tasks using the `task` function from `@trigger.dev/sdk/v3` and export them as shown in the correct pattern.
Applied to files:
apps/webapp/app/routes/api.v1.schedules.$scheduleId.tsapps/webapp/app/models/schedules.server.ts
📚 Learning: applies to **/trigger/**/*.{ts,tsx,js,jsx} : when using retry, queue, machine, or maxduration option...
Learnt from: CR
PR: triggerdotdev/trigger.dev#0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-07-18T17:50:25.014Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : When using retry, queue, machine, or maxDuration options, configure them as shown in the examples for Trigger.dev tasks.
Applied to files:
apps/webapp/app/routes/api.v1.schedules.$scheduleId.ts
📚 Learning: applies to **/trigger/**/*.{ts,tsx,js,jsx} : you must never use `client.definejob` in trigger.dev ta...
Learnt from: CR
PR: triggerdotdev/trigger.dev#0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-07-18T17:50:25.014Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : You MUST NEVER use `client.defineJob` in Trigger.dev task files.
Applied to files:
apps/webapp/app/routes/api.v1.schedules.$scheduleId.ts
📚 Learning: applies to **/trigger/**/*.{ts,tsx,js,jsx} : never generate deprecated code patterns using `client.d...
Learnt from: CR
PR: triggerdotdev/trigger.dev#0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-07-18T17:50:25.014Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : NEVER generate deprecated code patterns using `client.defineJob` and related deprecated APIs, as shown in the prohibited code block.
Applied to files:
apps/webapp/app/routes/api.v1.schedules.$scheduleId.ts
📚 Learning: applies to **/trigger/**/*.{ts,tsx,js,jsx} : the `run` function contains your task logic in trigger....
Learnt from: CR
PR: triggerdotdev/trigger.dev#0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-07-18T17:50:25.014Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : The `run` function contains your task logic in Trigger.dev tasks.
Applied to files:
apps/webapp/app/routes/api.v1.schedules.$scheduleId.activate.ts
📚 Learning: the `objecttosearchparams` function in `apps/webapp/app/utils/searchparams.ts` is used to generate u...
Learnt from: matt-aitken
PR: triggerdotdev/trigger.dev#2264
File: apps/webapp/app/utils/searchParams.ts:16-18
Timestamp: 2025-07-12T18:00:06.163Z
Learning: The `objectToSearchParams` function in `apps/webapp/app/utils/searchParams.ts` is used to generate URL parameters from objects and is separate from code that parses incoming search parameters. Changes to this function only affect places where it's used to create URLs, not places that parse search parameters from external sources.
Applied to files:
apps/webapp/app/v3/services/upsertTaskSchedule.server.tsapps/webapp/app/models/schedules.server.ts
📚 Learning: applies to apps/webapp/app/services/**/*.server.ts : for testable services, separate service logic a...
Learnt from: CR
PR: triggerdotdev/trigger.dev#0
File: .cursor/rules/webapp.mdc:0-0
Timestamp: 2025-07-18T17:49:47.180Z
Learning: Applies to apps/webapp/app/services/**/*.server.ts : For testable services, separate service logic and configuration, as exemplified by `realtimeClient.server.ts` (service) and `realtimeClientGlobal.server.ts` (configuration).
Applied to files:
apps/webapp/app/v3/services/upsertTaskSchedule.server.tsapps/webapp/app/models/schedules.server.ts
📚 Learning: applies to **/trigger/**/*.{ts,tsx,js,jsx} : each task needs a unique id within your project....
Learnt from: CR
PR: triggerdotdev/trigger.dev#0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-07-18T17:50:25.014Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Each task needs a unique ID within your project.
Applied to files:
apps/webapp/app/models/schedules.server.ts
🧬 Code Graph Analysis (4)
apps/webapp/app/routes/api.v1.schedules.$scheduleId.deactivate.ts (1)
apps/webapp/app/models/schedules.server.ts (2)
scheduleWhereClause(22-37)scheduleUniqWhereClause(3-20)
apps/webapp/app/routes/api.v1.schedules.$scheduleId.ts (1)
apps/webapp/app/models/schedules.server.ts (1)
scheduleUniqWhereClause(3-20)
apps/webapp/app/routes/api.v1.schedules.$scheduleId.activate.ts (1)
apps/webapp/app/models/schedules.server.ts (2)
scheduleWhereClause(22-37)scheduleUniqWhereClause(3-20)
apps/webapp/app/presenters/v3/ViewSchedulePresenter.server.ts (1)
apps/webapp/app/models/schedules.server.ts (1)
scheduleWhereClause(22-37)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (25)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (4, 10)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (4, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (8, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (2, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (5, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (7, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (8, 10)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (6, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (3, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (9, 10)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (7, 10)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (10, 10)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (1, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (3, 10)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (5, 10)
- GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - pnpm)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (6, 10)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (1, 10)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (2, 10)
- GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
- GitHub Check: units / packages / 🧪 Unit Tests: Packages (1, 1)
- GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - npm)
- GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
- GitHub Check: typecheck / typecheck
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (13)
apps/webapp/app/models/schedules.server.ts (2)
3-20: LGTM! Well-designed helper function for unique queries.The
scheduleUniqWhereClausefunction correctly handles both friendly IDs (starting with "sched_") and deduplication keys using the appropriate Prisma unique constraint patterns. The composite unique keyprojectId_deduplicationKeyis properly structured for the deduplication key case.
22-37: LGTM! Consistent design with the unique variant.The
scheduleWhereClausefunction mirrors the logic ofscheduleUniqWhereClausebut returns a standardWhereInputinstead ofWhereUniqueInput, making it suitable forfindFirstand similar operations. The consistent branching logic ensures both functions handle the same ID formats identically.apps/webapp/app/routes/api.v1.schedules.$scheduleId.ts (2)
6-6: LGTM! Proper import of the helper function.The import correctly brings in the
scheduleUniqWhereClausefunction needed for the delete operation.
40-43: LGTM! Correct usage of the helper function for delete operation.The
scheduleUniqWhereClausehelper is appropriately used here since Prisma'sdeleteoperation requires a unique where clause. The parameters are correctly passed:projectIdfrom the authenticated environment andscheduleIdfrom the parsed params.apps/webapp/app/v3/services/upsertTaskSchedule.server.ts (2)
10-10: LGTM! Proper import of the helper function.The import correctly brings in the
scheduleWhereClausefunction for use in the service.
41-41: LGTM! Centralized query logic improves consistency.The service now uses the centralized
scheduleWhereClausehelper function, which will correctly handle both friendly IDs and deduplication keys based on the ID format. This ensures consistent behavior across the application when querying schedules.apps/webapp/app/presenters/v3/ViewSchedulePresenter.server.ts (2)
7-7: LGTM! Proper import of the helper function.The import correctly brings in the
scheduleWhereClausefunction for use in the presenter.
67-67: LGTM! Centralized query logic supports dual ID format.The presenter now uses the
scheduleWhereClausehelper function, which enables it to handle both friendly IDs (starting with "sched_") and deduplication keys. This expands the presenter's capability beyond just friendly IDs, aligning with the PR objective to accept both deduplicationKeys and schedule IDs.apps/webapp/app/routes/api.v1.schedules.$scheduleId.deactivate.ts (3)
5-5: LGTM! Proper imports of both helper functions.The imports correctly bring in both
scheduleUniqWhereClauseandscheduleWhereClausefunctions needed for the different Prisma operations in this route.
37-40: LGTM! Correct usage of standard where clause for findFirst.The
scheduleWhereClausehelper is appropriately used for thefindFirstoperation, which accepts a standard where input rather than requiring a unique constraint.
48-51: LGTM! Correct usage of unique where clause for update.The
scheduleUniqWhereClausehelper is appropriately used for theupdateoperation, which requires a unique where clause. This ensures the update operation can correctly identify the specific schedule to modify.apps/webapp/app/routes/api.v1.schedules.$scheduleId.activate.ts (2)
5-5: Importing the shared helpers is spot-on
Re-usingscheduleUniqWhereClause/scheduleWhereClausekeeps the route logic DRY and aligned with the rest of the codebase.
57-63: Verify presenter lookup works fordeduplicationKeyroutes
If the caller supplied a plaindeduplicationKey(doesn’t start withsched_), we pass it asfriendlyId, which may causeViewSchedulePresenterto miss the record and return 404 even after a successful update.Please confirm
ViewSchedulePresenter.call()accepts both identifier shapes; otherwise, consider forwarding bothfriendlyIdanddeduplicationKey, or add a helper mirroringscheduleWhereClause.
2 participants
No description provided.