Skip to content

#1926 - apple #2364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

#1926 - apple #2364

wants to merge 1 commit into from

Conversation

swyxio
Copy link

@swyxio swyxio commented Aug 7, 2025

special pr for eric


Current Behavior

  • The extension checks if the schema is in a folder named schema (by checking if the parent dir of the schema path ends with "schema").
  • If so, it copies all .prisma files from that folder, but does not pass --schema to the prisma generate command (see lines 186–190).
  • If the schema is a file (not in a schema folder), it does pass --schema=./prisma/schema.prisma (lines 205–211).
  • This logic is now broken for Prisma 6.6.0+.

What Needs to Change

  1. Always pass --schema to the prisma generate command, regardless of folder or file.
  2. Stop inferring schema folder by directory name. Instead, always use the explicit path from config.
  3. (Optional, for future-proofing): Add support for reading schema path from prisma.config.ts or package.json if not provided in options, but for now, the extension already requires a schema option, so this is less urgent.
  4. Update comments and docs to reflect the new behavior.

Implementation Plan

  • In both the "schema folder" and "schema file" branches, always add --schema=<path> to the prisma generate command.
  • Remove the comment that says "Don't add the --schema flag or this will fail".
  • Make sure the path is correct (relative to the build output).

Next Step

I will update packages/build/src/extensions/prisma.ts so that:

  • Both code paths for schema folder and schema file always pass --schema=<path> to the prisma generate command.
  • The schema path used is always the one resolved from this.options.schema.

Let’s proceed with this change.
Ran tool
Ran tool
The code has been updated so that the Prisma extension always passes the --schema flag to the prisma generate command, regardless of whether the schema is in a folder or a file. The correct relative path is used in both cases, and the outdated comment was removed.

There are no linter errors in the updated file.

Next steps you may want to consider:

  • Test the extension with both schema file and schema folder setups on Prisma 6.6.0+.
  • Update documentation to clarify the new requirement and behavior.

Let me know if you want to proceed with further improvements, add support for prisma.config.ts, or update the docs!

Copy link

changeset-bot bot commented Aug 7, 2025

⚠️ No Changeset found

Latest commit: 7878973

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Aug 7, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ericallam ericallam closed this Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants