Skip to content

fix(cli): various mcp server fixes #2430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 21, 2025
Merged

fix(cli): various mcp server fixes #2430

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7c6cb14
fix: span events are optional, as logs don't have them
ericallam Aug 20, 2025
ca882a7
remove CI: true env var to prevent massive tool responses
ericallam Aug 20, 2025
20c547a
fix github resolver relative path
ericallam Aug 20, 2025
46248ff
prevent the dev command from asking for user input when not interactive
ericallam Aug 20, 2025
0747699
Remove lodash.get because it's deprecated
ericallam Aug 20, 2025
b994978
span output can be object other than an object, like a string
ericallam Aug 20, 2025
f1e430a
prevent large traces from causing get_run_details failures
ericallam Aug 20, 2025
f39dce7
Decreased max log lines, made it a tool input property
ericallam Aug 20, 2025
42d668e
Some install mcp tweaks
ericallam Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/cli-v3/src/mcp/tools/deploys.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ export const deployTool = {
cwd: cwd.cwd,
env: {
TRIGGER_MCP_SERVER: "1",
CI: "true",
},
},
});
Expand Down
2 changes: 1 addition & 1 deletion packages/cli-v3/src/rules/manifest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ export class GithubRulesManifestLoader implements RulesManifestLoader {

async loadRulesFile(relativePath: string): Promise<string> {
const response = await fetch(
`https://raw.githubusercontent.com/triggerdotdev/trigger.dev/refs/heads/${this.branch}/${relativePath}`
`https://raw.githubusercontent.com/triggerdotdev/trigger.dev/refs/heads/${this.branch}/rules/${relativePath}`
);

if (!response.ok) {
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/v3/schemas/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1233,7 +1233,7 @@ export const RetrieveRunTraceSpanSchema = z.object({
runId: z.string(),
taskSlug: z.string().optional(),
taskPath: z.string().optional(),
events: z.array(z.any()),
events: z.array(z.any()).optional(),
startTime: z.coerce.date(),
duration: z.number(),
isError: z.boolean(),
Expand Down
Loading