chore(webapp): improvements to app emails #2482
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,7 +26,6 @@ export const box = { | |
|
|
||
| export const hr = { | ||
| borderColor: "#272A2E", | ||
| }; | ||
|
|
||
| export const sans = { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,39 +1,67 @@ | ||
| import { | ||
| Body, | ||
| Button, | ||
| Container, | ||
| Hr, | ||
| Html, | ||
| Link, | ||
| Preview, | ||
| Section, | ||
| Text, | ||
| } from "@react-email/components"; | ||
| import { Tailwind } from "@react-email/tailwind"; | ||
| import { Footer } from "./components/Footer"; | ||
| import { Image } from "./components/Image"; | ||
| import { hr } from "./components/styles"; | ||
|
|
||
| export default function Email({ magicLink }: { magicLink: string }) { | ||
|
There was a problem hiding this comment. 🛠️ Refactor suggestion Switch to a named export per repo guidelines; also use a clearer component name. Avoid default exports. Rename to a named export to align with “No default exports, use function declarations”. -export default function Email({ magicLink }: { magicLink: string }) {
+export function MagicLinkEmail({ magicLink }: { magicLink: string }) {Run to find and update call sites that import the default: #!/bin/bash
# Find default imports of magic-link and re-export patterns using default
rg -nP -C1 '\bimport\s+Email\s+from\s+["\'][^"\']*magic-link' --type=ts --type=tsx
rg -nP -C1 'export\s*{\s*default\s+as\s+[^}]+}\s*from\s*["\'][^"\']*magic-link' --type=ts --type=tsx🤖 Prompt for AI Agents |
||
| return ( | ||
| <Html> | ||
| <Preview>Log in with this magic link</Preview> | ||
| <Tailwind> | ||
| <Body className="bg-[#121317] my-auto mx-auto font-sans"> | ||
| <Container className="my-[40px] mx-auto p-[20px] max-w-[600px]"> | ||
| <Section className="mt-[32px]"> | ||
| <Image | ||
| path="/emails/logo.png" | ||
| width="180px" | ||
| height="32px" | ||
| alt="Trigger.dev" | ||
| className="mt-0 mb-12" | ||
| /> | ||
| <Text className="text-[24px] font-bold text-[#D7D9DD] mb-8"> | ||
| Log in to Trigger.dev | ||
| </Text> | ||
| <Button | ||
| href={magicLink} | ||
| className="bg-[#A8FF53] rounded text-[#121317] text-[16px] no-underline text-center px-4 py-3 mb-8" | ||
| > | ||
| Log in with magic link | ||
| </Button> | ||
| </Section> | ||
| <Section className="mb-6"> | ||
| <Text className="text-[14px] text-[#878C99]"> | ||
| Can't see the button? Copy and paste this link into your browser:{" "} | ||
| </Text> | ||
| <Link | ||
| href={magicLink} | ||
| target="_blank" | ||
| className="text-[#6366F1] text-[14px] no-underline" | ||
| > | ||
| {magicLink} | ||
| </Link> | ||
| </Section> | ||
| <Section> | ||
| <Hr style={hr} /> | ||
| <Text className="text-[14px] mt-2 mb-0 text-[#878C99]"> | ||
| This link expires in 30 minutes and can only be used once. If you didn't try to | ||
| log in, you can safely ignore this email. | ||
| </Text> | ||
| </Section> | ||
| <Footer /> | ||
| </Container> | ||
| </Body> | ||
| </Tailwind> | ||
| </Html> | ||
| ); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,51 +1,64 @@ | ||
| import { Body, Container, Head, Html, Link, Preview, Text } from "@react-email/components"; | ||
| import { Tailwind } from "@react-email/tailwind"; | ||
| import { Footer } from "./components/Footer"; | ||
|
|
||
| export default function Email({ name }: { name?: string }) { | ||
|
There was a problem hiding this comment. 🛠️ Refactor suggestion Use a named export per repo guideline (no default exports). Switch to a named function export; consider a descriptive name. Apply: -export default function Email({ name }: { name?: string }) {
+export function WelcomeEmail({ name }: { name?: string }) {Update import sites accordingly. #!/bin/bash
rg -nP --type=ts --type=tsx -C2 'export\s+default\s+function\s+Email\(|from\s+["'\'']\./emails/welcome["'\'']'🤖 Prompt for AI Agents |
||
| return ( | ||
| <Html> | ||
| <Head /> | ||
| <Preview>Welcome to Trigger.dev</Preview> | ||
| <Tailwind> | ||
| <Body className="bg-[#121317] my-auto mx-auto font-sans"> | ||
| <Container className="mb-[40px] mx-auto p-[20px] max-w-[600px] text-[#D7D9DD]"> | ||
| <Text className="text-[16px]">Hey {name ?? "there"},</Text> | ||
| <Text className="text-[16px]">I’m Matt, CEO of Trigger.dev.</Text> | ||
| <Text className="text-[16px]"> | ||
| Our goal is to give developers like you the ability to effortlessly create powerful AI | ||
| agents and workflows in code. | ||
| </Text> | ||
| <Text className="text-[16px]"> | ||
| I recommend our{" "} | ||
| <Link | ||
| className="text-[#6366F1] text-[16px] no-underline" | ||
| href="https://trigger.dev/docs/quick-start" | ||
| > | ||
| quick start guide | ||
| </Link>{" "} | ||
| to get started, or{" "} | ||
| <Link | ||
| className="text-[#6366F1] text-[16px] no-underline" | ||
| href="https://trigger.dev/docs/guides/introduction" | ||
| > | ||
| one of our examples | ||
| </Link>{" "} | ||
| to get familiar with how Trigger.dev works, and then move on to create your own | ||
| workflow. | ||
| </Text> | ||
|
|
||
| <Text className="text-[16px]"> | ||
| Feel free to reply to this email if you have any questions or join our{" "} | ||
| <Link | ||
| className="text-[#6366F1] text-[16px] no-underline" | ||
| href="https://discord.gg/JtBAxBr2m3" | ||
| > | ||
| Discord | ||
| </Link>{" "} | ||
| to connect with the community and our team. | ||
| </Text> | ||
|
|
||
| <Text className="text-[16px]">We hope you enjoy using Trigger.dev!</Text> | ||
|
|
||
| <Text className="text-[16px]">Best,</Text> | ||
| <Text className="text-[16px]">Matt</Text> | ||
| <Text className="text-[16px]">CEO, Trigger.dev</Text> | ||
| <Text className="text-[16px]"> | ||
| If you don’t want me to contact you again, please just let me know and I’ll update | ||
| your preferences. | ||
| </Text> | ||
| <Footer /> | ||
| </Container> | ||
| </Body> | ||
| </Tailwind> | ||
| </Html> | ||
| ); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tailwind is imported from the wrong package and unused here.
Footer doesn’t use Tailwind; drop it from the import (and if needed elsewhere, import from @react-email/tailwind, not components).
Apply:
📝 Committable suggestion
🤖 Prompt for AI Agents