fix(packages): remove effect from optional peer dependencies

[ericallam]

Fixes ERROR: Could not resolve "effect"

[changeset-bot]

🦋 Changeset detected

Latest commit: d0e14a5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages

Name	Type
@trigger.dev/schema-to-json	Patch
trigger.dev	Patch
d3-chat	Patch
references-d3-openai-agents	Patch
references-nextjs-realtime	Patch
@trigger.dev/build	Patch
@trigger.dev/core	Patch
@trigger.dev/python	Patch
@trigger.dev/react-hooks	Patch
@trigger.dev/redis-worker	Patch
@trigger.dev/rsc	Patch
@trigger.dev/sdk	Patch
@trigger.dev/database	Patch
@trigger.dev/otlp-importer	Patch
@internal/cache	Patch
@internal/clickhouse	Patch
@internal/redis	Patch
@internal/replication	Patch
@internal/run-engine	Patch
@internal/schedule-engine	Patch
@internal/testcontainers	Patch
@internal/tracing	Patch
@internal/zod-worker	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[coderabbitai]

Walkthrough

• Added .changeset/brave-roses-cheat.md declaring a patch release for "@trigger.dev/schema-to-json", noting removal of Effect from optional peer dependencies as it is now a production dependency.
• Updated packages/schema-to-json/package.json by removing effect, yup, and zod from peerDependencies and their entries from peerDependenciesMeta.
• No source code or exported/public API signature changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The PR description contains only "Fixes ERROR: Could not resolve "effect"" and does not follow the repository's required template; it is missing the "Closes #" header, the checklist, explicit testing steps, a changelog entry, and the screenshots section, so the description is incomplete. Because these required sections are absent the check fails.	Please update the PR description to match the repository template: add "Closes #" or state none, complete the checklist, provide concrete testing steps that reproduce and verify the fix, include a short changelog entry summarizing the change, and attach screenshots if applicable. After updating the description, confirm CI/tests pass and add any relevant issue references before requesting review.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The PR title "fix(packages): remove effect from optional peer dependencies" is concise, follows conventional commit style, and accurately reflects the primary change in the diff (removing the 'effect' optional peer dependency to fix resolution errors), which aligns with the PR objectives and changeset. Although the package.json also removes other optional peers (yup and zod), the title highlights the root error addressed and is clear for history scanning.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch Lane-5

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

.changeset/brave-roses-cheat.md (1)

2-5: Expand the changeset to reflect all peerDependency removals.

The package.json also removes zod and yup from peerDependencies. Reflect that here to avoid confusing consumers reading release notes.

Apply:

----
-"@trigger.dev/schema-to-json": patch
----
-
-remove effect from optional peer dependencies since it's now a production dependency
+---
+"@trigger.dev/schema-to-json": patch
+---
+
+Remove effect, zod, and yup from optional peerDependencies. effect is now a production dependency; zod is a direct dependency (for zod-to-json-schema); yup is dev-only (tests).

packages/schema-to-json/package.json (1)

43-49: Confirm semver strategy for production deps (effect).

effect is now a prod dependency with range ^3. Ensure this aligns with repo policy (others like zod are pinned). If you want reproducibility, consider pinning or using an internal resolution strategy.

Would you like me to check repository-wide conventions and open a follow-up PR to normalize dependency ranges?

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ad51168 and d0e14a5.

📒 Files selected for processing (2)

• .changeset/brave-roses-cheat.md (1 hunks)
• packages/schema-to-json/package.json (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (23)

• GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (8, 8)
• GitHub Check: units / internal / 🧪 Unit Tests: Internal (3, 8)
• GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (7, 8)
• GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (6, 8)
• GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (4, 8)
• GitHub Check: units / internal / 🧪 Unit Tests: Internal (6, 8)
• GitHub Check: units / internal / 🧪 Unit Tests: Internal (4, 8)
• GitHub Check: units / internal / 🧪 Unit Tests: Internal (8, 8)
• GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (5, 8)
• GitHub Check: units / internal / 🧪 Unit Tests: Internal (7, 8)
• GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (3, 8)
• GitHub Check: units / internal / 🧪 Unit Tests: Internal (5, 8)
• GitHub Check: units / internal / 🧪 Unit Tests: Internal (2, 8)
• GitHub Check: units / internal / 🧪 Unit Tests: Internal (1, 8)
• GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (1, 8)
• GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (2, 8)
• GitHub Check: units / packages / 🧪 Unit Tests: Packages (1, 1)
• GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - pnpm)
• GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
• GitHub Check: typecheck / typecheck
• GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - npm)
• GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
• GitHub Check: Analyze (javascript-typescript)

🔇 Additional comments (3)

packages/schema-to-json/package.json (3)

68-84: peerDependenciesMeta correctly mirrors remaining peers.

Meta entries align with current peerDependencies after removals. LGTM.

---

46-49: No peerDependency on "yup" in @sodaru/yup-to-json-schema — no action required.
Upstream package.json lists "yup" only in devDependencies (^1.1.1), not as a peerDependency.

---

61-67: OK — no runtime 'yup' imports found in packages/schema-to-json
Searched packages/schema-to-json/src for static (value) imports, require(...), and dynamic import(...): no value imports of "yup" found; no "zod" imports detected.