fix(api): 204 response issue in deployment start endpoint

[myftija]

No description provided.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 18c28fa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The change updates a single route handler at apps/webapp/app/routes/api.v1.deployments.$deploymentId.start.ts. Two 204 No Content responses previously returned via json(null, { status: 204 }) are replaced with new Response(null, { status: 204 }). These occur in the success branch of deploymentService.startDeployment(...).match and in the specific error branch for type "failed_to_extend_deployment_timeout". Other branches are unchanged: "deployment_not_found" returns 404, "deployment_not_pending" returns 409, and the default error returns 500.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-response-issue-start-endpoint

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8313800 and 18c28fa.

📒 Files selected for processing (1)

• apps/webapp/app/routes/api.v1.deployments.$deploymentId.start.ts (1 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}