-
-
Notifications
You must be signed in to change notification settings - Fork 896
feat(otel): add prisma operation name to tree view for easier scanning #2707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
WalkthroughThis pull request modifies the Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
apps/webapp/app/v3/utils/enrichCreatableEvents.server.ts (1)
27-49: Well-structured Prisma operation handling with proper type safety.The implementation correctly:
- Identifies Prisma client operation events by message
- Type-guards the operation name before use
- Creates an accessory codepath structure for the tree view
- Falls back gracefully when the name isn't a string
The pattern is consistent with existing style enrichment logic in this file.
Optional consideration: If
operationNameis an empty string, an empty accessory will be displayed. This is likely acceptable behavior, but you may want to add an additional check likeoperationName.trim() !== ""if empty accessories should be avoided.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/webapp/app/v3/utils/enrichCreatableEvents.server.ts(2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 2390
File: internal-packages/run-engine/src/engine/index.ts:466-467
Timestamp: 2025-08-14T10:09:02.528Z
Learning: In the triggerdotdev/trigger.dev codebase, it's acceptable to pass `string | undefined` types directly to Prisma operations (both create and update). The codebase consistently uses this pattern and the team is comfortable with how Prisma handles undefined values.
🧬 Code graph analysis (1)
apps/webapp/app/v3/utils/enrichCreatableEvents.server.ts (2)
packages/core/src/v3/index.ts (1)
flattenAttributes(46-46)packages/core/src/v3/utils/flattenAttributes.ts (1)
flattenAttributes(6-14)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (23)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (5, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (6, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (4, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (8, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (7, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (3, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (6, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (5, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (1, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (2, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (8, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (7, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (1, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (3, 8)
- GitHub Check: units / packages / 🧪 Unit Tests: Packages (1, 1)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (4, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (2, 8)
- GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
- GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - npm)
- GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - pnpm)
- GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
- GitHub Check: typecheck / typecheck
- GitHub Check: Analyze (javascript-typescript)
| @@ -1,3 +1,4 @@ | |||
| import { accessoryAttributes, flattenAttributes } from "@trigger.dev/core/v3"; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Verify usage of accessoryAttributes import.
The flattenAttributes import is correctly used in the new Prisma operation handling. However, accessoryAttributes doesn't appear to be used in this file. Please verify whether this import is necessary or if it can be removed.
🏁 Script executed:
#!/bin/bash
# Description: Check if accessoryAttributes is used in the enrichCreatableEvents.server.ts file
# Search for usage of accessoryAttributes in the file
rg -n 'accessoryAttributes' apps/webapp/app/v3/utils/enrichCreatableEvents.server.tsLength of output: 80
Remove unused accessoryAttributes import.
The accessoryAttributes is imported on line 1 but never used in this file. Only flattenAttributes is actively used in the new Prisma operation handling code. Remove accessoryAttributes from the import statement:
import { flattenAttributes } from "@trigger.dev/core/v3";
🤖 Prompt for AI Agents
In apps/webapp/app/v3/utils/enrichCreatableEvents.server.ts around line 1, the
import statement includes an unused symbol `accessoryAttributes`; remove it so
only `flattenAttributes` is imported from "@trigger.dev/core/v3". Update the
import to drop `accessoryAttributes` and ensure no other references to it exist
in the file.
Uh oh!
There was an error while loading. Please reload this page.