-
-
Notifications
You must be signed in to change notification settings - Fork 950
feat: add reverse replay tracking with "Replayed as" section in Details tab #2832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
matt-aitken
wants to merge
1
commit into
main
Choose a base branch
from
claude/slack-add-original-run-reference-BwAhT
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
internal-packages/clickhouse/schema/012_add_task_runs_v2_replayed_from.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| -- +goose Up | ||
| /* | ||
| Add replayed_from_friendly_id column to track which run this was replayed from. | ||
| */ | ||
| ALTER TABLE trigger_dev.task_runs_v2 | ||
| ADD COLUMN replayed_from_friendly_id String DEFAULT ''; | ||
|
|
||
| -- +goose Down | ||
| ALTER TABLE trigger_dev.task_runs_v2 | ||
| DROP COLUMN replayed_from_friendly_id; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: triggerdotdev/trigger.dev
Length of output: 5469
🏁 Script executed:
Repository: triggerdotdev/trigger.dev
Length of output: 24510
🏁 Script executed:
Repository: triggerdotdev/trigger.dev
Length of output: 4525
🏁 Script executed:
Repository: triggerdotdev/trigger.dev
Length of output: 166
🏁 Script executed:
Repository: triggerdotdev/trigger.dev
Length of output: 820
🏁 Script executed:
Repository: triggerdotdev/trigger.dev
Length of output: 2125
🏁 Script executed:
Repository: triggerdotdev/trigger.dev
Length of output: 128
🏁 Script executed:
Repository: triggerdotdev/trigger.dev
Length of output: 409
Remove the
as anytype assertion and properly type the replay status field.Line 731 uses
as anyto castreplay.statusto satisfyTaskRunStatusCombo, which expects aTaskRunStatustype. The issue stems from the#getRunReplays()method returningstatus: stringinstead ofstatus: TaskRunStatus.Fix this by updating the return type of
#getRunReplays()inSpanPresenter.server.tsto:This ensures type safety without needing the
as anycast. The method can validate or coerce the ClickHouse string values to the properTaskRunStatustype before returning.🤖 Prompt for AI Agents