feat: add ppx_forbid to enforce Eio-safe coding rules#118
Merged
mathiasbourgoin merged 1 commit intomainfrom Feb 18, 2026
Merged
feat: add ppx_forbid to enforce Eio-safe coding rules#118mathiasbourgoin merged 1 commit intomainfrom
mathiasbourgoin merged 1 commit intomainfrom
Conversation
Add ppx_forbid as a build dependency and enable it across all source libraries. The .ppx_forbid config forbids Obj, blocking Unix/Thread calls, and direct stdout/stderr writes — all patterns that break in an Eio-based TUI framework. Existing legitimate uses are annotated with [@allow_forbidden "reason"].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.ppx_forbidconfig forbidding unsafe patterns in an Eio-based TUI framework:Objmodule (breaks type safety)Unix.sleep/sleepf,Unix.open_process_*,Unix.systemThread.create/delayprint_endline,print_string,prerr_endline, etc.ppx_forbidacross all 20 src/ libraries[@allow_forbidden "reason"]Test plan
dune build— clean, no ppx_forbid errorsdune runtest— all tests passdune fmt— formatting applied