fix(web): prevent browser from capturing Tab and other reserved keys#126
Merged
mathiasbourgoin merged 1 commit intomainfrom Feb 26, 2026
Merged
fix(web): prevent browser from capturing Tab and other reserved keys#126mathiasbourgoin merged 1 commit intomainfrom
mathiasbourgoin merged 1 commit intomainfrom
Conversation
Call ev.preventDefault() when a key is recognized in the web client's keyboard handler. Previously Tab triggered browser focus navigation instead of reaching the Miaou application. Also fix test_canvas: update expected ANSI output for empty canvas to include the SGR reset emitted at col 0 since the 0.4.2 row-isolation fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ev.preventDefault()in the web client keyboard handler when a key is recognized, so the browser does not also act on it (Tab for focus navigation, F5 for reload, etc.)test_canvasempty-canvas ANSI test to match the new SGR-at-col-0 behaviour introduced in 0.4.2Test plan
dune build)dune test)