Skip to content

Fix React Native builds #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akennedyTrimble merged 3 commits into from
Sep 22, 2025
Merged

Fix React Native builds #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be36652
Fix iOS React Native build
akennedyTrimble Sep 22, 2025
df305d4
Fix Android React Native build
akennedyTrimble Sep 22, 2025
46b9a42
Remove flipper_config line in Podfile
akennedyTrimble Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...blemaps-mobile-sdk-demo-reactnative/react_native/RNMapsSampleApp/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ android {
compileSdkVersion rootProject.ext.compileSdkVersion
buildToolsVersion rootProject.ext.buildToolsVersion

namespace "com.mapssampleapp"

sourceSets {
main {
jniLibs.srcDirs = ['src/jniLibs']
Expand Down
2 changes: 1 addition & 1 deletion ...trimblemaps-mobile-sdk-demo-reactnative/react_native/RNMapsSampleApp/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ buildscript {
compileSdkVersion = 33
targetSdkVersion = 33
ndkVersion = "21.4.7075529"
kotlinVersion = "1.8.20"
kotlinVersion = "1.8.10"
}
repositories {
mavenLocal()
Expand Down
2 changes: 1 addition & 1 deletion ...reactnative/react_native/RNMapsSampleApp/android/gradle/wrapper/gradle-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.5-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.3-all.zip
7 changes: 6 additions & 1 deletion ...tive/trimblemaps-mobile-sdk-demo-reactnative/react_native/RNMapsSampleApp/babel.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
module.exports = {
presets: ["module:metro-react-native-babel-preset"]
presets: ["module:metro-react-native-babel-preset"],
plugins: [
["@babel/plugin-transform-class-properties", { "loose": true }],
["@babel/plugin-transform-private-methods", { "loose": true }],
["@babel/plugin-transform-private-property-in-object", { "loose": true }]
]
}
12 changes: 10 additions & 2 deletions ...t_native/trimblemaps-mobile-sdk-demo-reactnative/react_native/RNMapsSampleApp/ios/Podfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,23 @@ setup_permissions([
# dependencies: {
# ...(process.env.NO_FLIPPER ? { 'react-native-flipper': { platforms: { ios: null } } } : {}),
# ```
flipper_config = ENV['NO_FLIPPER'] == "1" ? FlipperConfiguration.disabled : FlipperConfiguration.enabled

linkage = ENV['USE_FRAMEWORKS']
if linkage != nil
Pod::UI.puts "Configuring Pod with #{linkage}ally linked Frameworks".green
use_frameworks! :linkage => linkage.to_sym
end

pre_install do |installer|
installer.pod_targets.each do |pod|
if pod.name.eql?('RNReanimated')
def pod.build_type;
Pod::BuildType.static_library
end
end
end
end

target 'RNMapsSampleApp' do
use_frameworks! :linkage => :dynamic
config = use_native_modules!
Expand Down Expand Up @@ -82,6 +91,5 @@ target 'RNMapsSampleApp' do
config[:reactNativePath],
:mac_catalyst_enabled => false
)
__apply_Xcode_12_5_M1_post_install_workaround(installer)
end
end
Loading