New Settings and Biometric Auth

[trinadhthatakula]

• Biometric Authentication: Implemented biometric lock functionality, allowing users to secure the app with fingerprint or device credentials. The app now routes through an authentication screen if enabled, with fallback options for errors or un-enrolled biometrics.
• New Settings Screen: Introduced a dedicated settings screen to manage various app preferences, including theme customization and security options.
• Enhanced Theming Options: Added comprehensive theme controls, allowing users to select between Light, Dark, or System theme modes, enable AMOLED mode for pure black backgrounds, and toggle dynamic color based on wallpaper (Android 12+).
• Refactored Installer Logic: Improved the Shizuku and Dhizuku package installer implementations with better error handling and a robust fallback mechanism to the normal installer if privileged installation fails. This also includes a new utility for creating privileged PackageInstallers.
• UI Component Modernization: Replaced SingleChoiceSegmentedButtonRow with a new, reusable ConnectedButtonGroup composable component across the app (AppListScreen, FreezerScreen, DashboardHeader, AppFilterSheet) for a more consistent and flexible UI.
• Funding Options Expansion: Updated the project's funding configuration to include Ko-fi and a custom PayPal link, and reflected these changes in the README.md.
• Build System Updates: Upgraded various dependencies including Android Gradle Plugin (AGP), Material3, KSP, and Coil3, and updated the Gradle wrapper to 9.4.0-rc-1.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch master

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the user experience by introducing new personalization and security features. Users can now customize the app's appearance with detailed theming options and protect access using biometric authentication. Additionally, the underlying package installation logic has been made more resilient, and several UI components have been modernized for improved consistency and maintainability across the application.

Highlights

• Biometric Authentication: Implemented biometric lock functionality, allowing users to secure the app with fingerprint or device credentials. The app now routes through an authentication screen if enabled, with fallback options for errors or un-enrolled biometrics.
• New Settings Screen: Introduced a dedicated settings screen to manage various app preferences, including theme customization and security options.
• Enhanced Theming Options: Added comprehensive theme controls, allowing users to select between Light, Dark, or System theme modes, enable AMOLED mode for pure black backgrounds, and toggle dynamic color based on wallpaper (Android 12+).
• Refactored Installer Logic: Improved the Shizuku and Dhizuku package installer implementations with better error handling and a robust fallback mechanism to the normal installer if privileged installation fails. This also includes a new utility for creating privileged PackageInstallers.
• UI Component Modernization: Replaced SingleChoiceSegmentedButtonRow with a new, reusable ConnectedButtonGroup composable component across the app (AppListScreen, FreezerScreen, DashboardHeader, AppFilterSheet) for a more consistent and flexible UI.
• Funding Options Expansion: Updated the project's funding configuration to include Ko-fi and a custom PayPal link, and reflected these changes in the README.md.
• Build System Updates: Upgraded various dependencies including Android Gradle Plugin (AGP), Material3, KSP, and Coil3, and updated the Gradle wrapper to 9.4.0-rc-1.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• .github/FUNDING.yml
  • Added Ko-fi and custom PayPal funding links.
• README.md
  • Updated APK size estimates to reflect current state.
  • Added 'Fingerprint Lock' and 'Themes' to the list of working features.
  • Included 'Dhizuku Support (testing)' in working features.
  • Introduced a new 'Support Development' section with links to Patreon, Buy Me a Coffee, and PayPal.
• app/build.gradle.kts
  • Added androidx.biometric dependency for biometric authentication.
  • Configured dependenciesInfo to exclude from APK but include in bundle.
  • Updated various library versions.
• app/src/main/java/com/valhalla/thor/HomeActivity.kt
  • Changed HomeActivity to extend FragmentActivity to support biometric prompts.
  • Integrated SecurityViewModel and SettingsViewModel for managing app state.
  • Implemented biometric authentication flow at app launch, displaying BiometricScreen if required.
  • Applied theme preferences (darkTheme, dynamicColor, amoledMode) from SettingsViewModel to ThorTheme.
• app/src/main/java/com/valhalla/thor/data/repository/InstallerRepositoryImpl.kt
  • Removed direct IPackageManager import.
  • Refactored getDhizukuPackageInstaller and added getShizukuPackageInstaller to use ShizukuPackageInstallerUtils for privileged installer creation.
  • Modified performPackageInstallerInstall to include an emitErrors parameter, allowing silent fallbacks for privileged installers.
  • Improved error handling for session creation and opening within performPackageInstallerInstall.
• app/src/main/java/com/valhalla/thor/data/repository/PreferenceRepositoryImpl.kt
  • Expanded Keys object to include new preferences for theme (THEME_MODE, USE_DYNAMIC_COLOR, USE_AMOLED) and security (BIOMETRIC_LOCK).
  • Updated userPreferences flow to map and retrieve new theme and security settings.
  • Added suspend functions (setThemeMode, setDynamicColor, setUseAmoled, setBiometricLock) to update new preferences.
• app/src/main/java/com/valhalla/thor/data/security/BiometricHelper.kt
  • Added a new class BiometricHelper to provide a thin wrapper around BiometricManager for checking biometric capabilities.
• app/src/main/java/com/valhalla/thor/data/source/local/shizuku/ShizukuReflector.kt
  • Added createPackageInstallerFor method to create a privileged PackageInstaller for a specific package name, leveraging ShizukuPackageInstallerUtils.
• app/src/main/java/com/valhalla/thor/di/Modules.kt
  • Registered BiometricHelper as a Koin singleton.
  • Registered SettingsViewModel and SecurityViewModel as Koin ViewModels.
• app/src/main/java/com/valhalla/thor/domain/model/ThemeMode.kt
  • Added a new enum class ThemeMode (LIGHT, DARK, SYSTEM) with a label() function.
• app/src/main/java/com/valhalla/thor/domain/model/UserPreferences.kt
  • Added new fields to UserPreferences data class: themeMode, useDynamicColor, useAmoled, and biometricLockEnabled.
• app/src/main/java/com/valhalla/thor/domain/repository/PreferenceRepository.kt
  • Added new suspend functions to the PreferenceRepository interface for managing theme (setThemeMode, setDynamicColor, setUseAmoled) and security (setBiometricLock) preferences.
• app/src/main/java/com/valhalla/thor/presentation/appList/AppListScreen.kt
  • Replaced SingleChoiceSegmentedButtonRow with the new ConnectedButtonGroup for app type switching.
• app/src/main/java/com/valhalla/thor/presentation/common/components/ConnectedButtonGroup.kt
  • Added a new composable ConnectedButtonGroup for creating single-select segmented button groups with icon, label, or icon-with-label items.
• app/src/main/java/com/valhalla/thor/presentation/freezer/FreezerScreen.kt
  • Replaced SingleChoiceSegmentedButtonRow with the new ConnectedButtonGroup for app source switching.
• app/src/main/java/com/valhalla/thor/presentation/home/AppDestinations.kt
  • Added SETTINGS as a new AppDestinations entry.
• app/src/main/java/com/valhalla/thor/presentation/home/components/DashboardHeader.kt
  • Replaced SingleChoiceSegmentedButtonRow with the new ConnectedButtonGroup for app type switching.
• app/src/main/java/com/valhalla/thor/presentation/main/MainScreen.kt
  • Integrated SettingsScreen into the navigation composable, accessible via AppDestinations.SETTINGS.
• app/src/main/java/com/valhalla/thor/presentation/security/AuthState.kt
  • Added a new sealed interface AuthState to define the app's authentication states (NotRequired, Locked, Unlocked, Error).
• app/src/main/java/com/valhalla/thor/presentation/security/BiometricPromptHandler.kt
  • Added a new internal object BiometricPromptHandler (currently minimal) for biometric prompt interactions.
• app/src/main/java/com/valhalla/thor/presentation/security/BiometricScreen.kt
  • Added a new composable BiometricScreen to handle biometric authentication, displaying a system prompt or an error screen with retry/exit options.
• app/src/main/java/com/valhalla/thor/presentation/security/SecurityViewModel.kt
  • Added a new SecurityViewModel to manage the app's biometric authentication state, including session authentication, error handling, and retry logic.
• app/src/main/java/com/valhalla/thor/presentation/settings/SettingsScreen.kt
  • Added a new composable SettingsScreen to display and manage app settings, including appearance (theme, AMOLED, dynamic color) and security (biometric lock) options.
  • Implemented logic to guide users to device settings if biometric hardware is present but not enrolled.
• app/src/main/java/com/valhalla/thor/presentation/settings/SettingsViewModel.kt
  • Added a new SettingsViewModel to expose user preferences and provide functions to update theme and biometric lock settings, leveraging BiometricHelper.
• app/src/main/java/com/valhalla/thor/presentation/theme/Theme.kt
  • Modified ThorTheme composable to accept an amoledMode parameter.
  • Applied a pure black background and surface color when darkTheme and amoledMode are both true.
• app/src/main/java/com/valhalla/thor/presentation/widgets/AppList.kt
  • Replaced SingleChoiceSegmentedButtonRow with the new ConnectedButtonGroup in the AppFilterSheet.
• app/src/main/res/drawable/theme_panel.xml
  • Added a new vector drawable for a theme panel icon.
• build.gradle.kts
  • Removed the kotlin-android plugin alias.
  • Updated Android Gradle Plugin (AGP) version.
• gradle.properties
  • Commented out ksp.use.k2 property.
  • Updated initialVersionCode, versionCode, and versionName.
• gradle/libs.versions.toml
  • Updated agp to 9.2.0-alpha02.
  • Added biometric library version 1.2.0-alpha05.
  • Updated ksp to 2.3.6.
  • Updated material3 to 1.5.0-alpha15.
  • Updated coil3 to 3.4.0.
  • Removed unused benchmarking and profiling dependencies (annotationJvm, uiautomator, benchmarkMacroJunit4, baselineprofile, profileinstaller).
• gradle/wrapper/gradle-wrapper.properties
  • Updated Gradle distribution URL to gradle-9.4.0-rc-1-bin.zip.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces significant new features, including a comprehensive settings screen, theme customization with an AMOLED mode, and biometric authentication. The implementation is well-structured, introducing new ViewModels, state management for security, and reusable UI components like ConnectedButtonGroup. The installer logic has also been made more robust with a fallback mechanism. The code quality is generally high, but there are a few areas for improvement regarding code cleanup and best practices detailed in the comments.

[gemini-code-assist]

The new function createPackageInstallerFor appears to be unused in the project. Furthermore, its logic is almost identical to the getShizukuPackageInstaller function in InstallerRepositoryImpl. This introduces code duplication and dead code. To improve maintainability, this unused function should be removed.

[gemini-code-assist]

The string "Appearance" is hardcoded. For better maintainability and to support localization in the future, it's recommended to extract UI strings into strings.xml resource files and reference them using stringResource(R.string.your_string_id). This applies to other hardcoded strings in this file as well.

Suggested change

	SettingsSectionLabel("Appearance")
	SettingsSectionLabel(stringResource(R.string.settings_appearance))

[Copilot]

Pull request overview

Adds a new in-app Settings experience (theme + security) and introduces biometric authentication gating at app launch, along with UI component refactors and build/dependency updates.

Changes:

• Add Settings screen + persistence for theme mode, dynamic color, AMOLED mode, and biometric-lock preference (DataStore).
• Add biometric lock gate (auth state VM + biometric prompt/error UI) and wire it into HomeActivity.
• Introduce ConnectedButtonGroup and replace SegmentedButton usage across multiple screens; update Gradle/versions and installer fallback logic.

Reviewed changes

Copilot reviewed 30 out of 31 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
gradle/wrapper/gradle-wrapper.properties	Updates Gradle wrapper distribution URL.
gradle/libs.versions.toml	Updates version catalog (AGP/KSP/material3/coil) and adds Biometric dependency entry; removes some catalog entries.
gradle.properties	Disables ksp.use.k2 and bumps app version code/name.
build.gradle.kts	Adjusts top-level plugin aliases (comment removal).
app/src/main/res/drawable/theme_panel.xml	Adds a new theme-related vector drawable for Settings UI.
app/src/main/java/com/valhalla/thor/presentation/widgets/AppList.kt	Replaces segmented tabs in filter sheet with ConnectedButtonGroup.
app/src/main/java/com/valhalla/thor/presentation/theme/Theme.kt	Adds AMOLED theme override support in ThorTheme.
app/src/main/java/com/valhalla/thor/presentation/settings/SettingsViewModel.kt	New VM to expose preferences + update theme/security settings.
app/src/main/java/com/valhalla/thor/presentation/settings/SettingsScreen.kt	New Settings UI with theme controls, dynamic color, AMOLED, biometric lock, and about links.
app/src/main/java/com/valhalla/thor/presentation/security/SecurityViewModel.kt	New VM that derives AuthState from preferences/session/error.
app/src/main/java/com/valhalla/thor/presentation/security/BiometricScreen.kt	New biometric prompt + error UI and prompt orchestration.
app/src/main/java/com/valhalla/thor/presentation/security/BiometricPromptHandler.kt	Adds placeholder handler object for biometric interactions.
app/src/main/java/com/valhalla/thor/presentation/security/AuthState.kt	Defines auth gate state model for biometric lock flow.
app/src/main/java/com/valhalla/thor/presentation/main/MainScreen.kt	Adds Settings destination rendering.
app/src/main/java/com/valhalla/thor/presentation/home/components/DashboardHeader.kt	Replaces segmented app-type switcher with ConnectedButtonGroup.
app/src/main/java/com/valhalla/thor/presentation/home/AppDestinations.kt	Enables Settings destination in bottom navigation.
app/src/main/java/com/valhalla/thor/presentation/freezer/FreezerScreen.kt	Replaces segmented app-type switcher with ConnectedButtonGroup.
app/src/main/java/com/valhalla/thor/presentation/common/components/ConnectedButtonGroup.kt	Adds reusable connected toggle button group component.
app/src/main/java/com/valhalla/thor/presentation/appList/AppListScreen.kt	Replaces segmented app-type switcher with ConnectedButtonGroup.
app/src/main/java/com/valhalla/thor/domain/repository/PreferenceRepository.kt	Extends preferences API for theme + security settings.
app/src/main/java/com/valhalla/thor/domain/model/UserPreferences.kt	Adds theme/security fields to preferences domain model.
app/src/main/java/com/valhalla/thor/domain/model/ThemeMode.kt	Adds ThemeMode enum for theme selection.
app/src/main/java/com/valhalla/thor/di/Modules.kt	Wires new VMs and BiometricHelper into Koin modules.
app/src/main/java/com/valhalla/thor/data/source/local/shizuku/ShizukuReflector.kt	Adds privileged PackageInstaller creation helper; tweaks uninstall flow block.
app/src/main/java/com/valhalla/thor/data/security/BiometricHelper.kt	Adds biometric capability helper wrapper around BiometricManager.
app/src/main/java/com/valhalla/thor/data/repository/PreferenceRepositoryImpl.kt	Persists new theme/security preferences in DataStore and maps them to domain.
app/src/main/java/com/valhalla/thor/data/repository/InstallerRepositoryImpl.kt	Adds privileged-installer fallbacks and refactors Shizuku/Dhizuku install handling.
app/src/main/java/com/valhalla/thor/HomeActivity.kt	Applies theme preferences + gates app entry with biometric auth state.
app/build.gradle.kts	Adds Biometric dependency and configures dependenciesInfo.
README.md	Documents new features (fingerprint lock, themes) and adds support/donation section.
.github/FUNDING.yml	Updates funding links (Ko-fi + PayPal custom).

Comments suppressed due to low confidence (1)

app/src/main/java/com/valhalla/thor/data/repository/InstallerRepositoryImpl.kt:37

• shizukuReflector is now injected but never used (only suppressed). This adds unnecessary DI wiring and can confuse future maintenance. Remove the constructor parameter and update the Koin module wiring accordingly, or start using it (e.g., via createPackageInstallerFor() if that’s the intent).

class InstallerRepositoryImpl(
    private val context: Context,
    private val eventBus: InstallerEventBus,
    private val rootGateway: RootSystemGateway,
    private val shizukuReflector: ShizukuReflector
) : InstallerRepository {

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The wrapper is being bumped to a Gradle release-candidate (9.4.0-rc-1). RC tooling can be unstable and may break CI/reproducible builds unexpectedly. Prefer pinning the wrapper to the latest stable Gradle distribution unless there is a concrete requirement for the RC.

[Copilot]

Modifier.animateWidth(interactionSource) is used but there is no import or local definition for animateWidth, so this will be an unresolved reference at compile time. Add the correct import for the Material3 expressive animateWidth modifier (or replace this call with the intended animation modifier).

[Copilot]

getDhizukuPackageInstaller() is currently using ShizukuPackageInstallerUtils, which wraps the PackageManager binder using ShizukuBinderWrapper. That won’t work in Dhizuku mode and effectively disables/breaks the Dhizuku install path (it will always throw and fall back to the normal installer). Rework this to obtain an IPackageInstaller via Dhizuku’s binder wrapper/API (similar to the previous approach / DhizukuHelper) so InstallMode.DHIZUKU actually uses Dhizuku.

[Copilot]

For BIOMETRIC_ERROR_NONE_ENROLLED, the code calls onAuthenticated() (fail-open). If the user enabled “Biometric Lock” and later removes biometrics/device credential, this bypasses the lock entirely, undermining the feature. Instead, treat this as a locked/error state (e.g., show an error with a link to enroll credentials, or disable the preference and require explicit user action).

Suggested change

	// No credentials enrolled — fail open so user is never locked out.
	onAuthenticated()
	// No biometrics or device credentials enrolled — keep locked and require user action.
	onError("No biometric or device credential is enrolled. Please enroll one in system settings to use biometric lock.")

[Copilot]

This block computes whether the app is still an updated system app but discards the result, so it has no effect and is misleading. Either remove this check entirely or use the result (e.g., log it or return it / branch on it) to justify why it exists.

Suggested change

	// Check if package still has updates; value intentionally ignored here
	(updatedPackageInfo.applicationInfo!!.flags and ApplicationInfo.FLAG_UPDATED_SYSTEM_APP) != 0
	// Check if package still has updates and log the result
	val stillUpdatedSystemApp =
	(updatedPackageInfo.applicationInfo!!.flags and ApplicationInfo.FLAG_UPDATED_SYSTEM_APP) != 0
	Logger.d(
	"ShizukuReflector",
	"Package $packageName still updated system app after uninstall: $stillUpdatedSystemApp"
	)