Skip to content

Don't require adding the https port in additionalExposedPorts when https is enabled #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2025
Merged

Don't require adding the https port in additionalExposedPorts when https is enabled #322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fa640e
include https port where needed when https is enabled
cccs-nik Mar 25, 2025
51a9cc4
removing duplicate https port from test values file
cccs-nik Mar 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions charts/trino/templates/deployment-coordinator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,11 @@ spec:
- name: http
containerPort: {{ .Values.service.port }}
protocol: TCP
{{- if .Values.server.config.https.enabled }}
- name: https
containerPort: {{ .Values.server.config.https.port }}
protocol: TCP
{{- end }}
{{- if $coordinatorJmx.enabled }}
- name: jmx-registry
containerPort: {{ $coordinatorJmx.registryPort }}
Expand Down
5 changes: 5 additions & 0 deletions charts/trino/templates/deployment-worker.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,11 @@ spec:
- name: http
containerPort: {{ .Values.service.port }}
protocol: TCP
{{- if .Values.server.config.https.enabled }}
- name: https
containerPort: {{ .Values.server.config.https.port }}
protocol: TCP
{{- end }}
{{- if $workerJmx.enabled }}
- name: jmx-registry
containerPort: {{ $workerJmx.registryPort }}
Expand Down
4 changes: 4 additions & 0 deletions charts/trino/templates/ingress.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,11 @@ spec:
service:
name: {{ include "trino.fullname" $ }}
port:
{{- if $.Values.server.config.https.enabled }}
number: {{ $.Values.server.config.https.port }}
{{- else }}
number: {{ $.Values.service.port }}
{{- end }}
{{- end }}
{{- end }}
{{- end }}
6 changes: 6 additions & 0 deletions charts/trino/templates/service-coordinator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,12 @@ spec:
{{- if .Values.service.nodePort }}
nodePort: {{ .Values.service.nodePort }}
{{- end }}
{{- if .Values.server.config.https.enabled }}
- port: {{ .Values.server.config.https.port }}
targetPort: https
protocol: TCP
name: https
{{- end }}
{{- if $coordinatorJmx.exporter.enabled }}
- port: {{ $coordinatorJmx.exporter.port }}
targetPort: jmx-exporter
Expand Down
7 changes: 0 additions & 7 deletions tests/trino/test-values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,13 +100,6 @@ coordinator:
mountPath: /etc/trino/generated
readOnly: false

additionalExposedPorts:
https:
servicePort: 8443
name: https
port: 8443
protocol: TCP

annotations:
custom/name: value

Expand Down