Skip to content

Add resource related comments #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add resource related comments #364

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions charts/trino/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ server:
# PASSWORD, CERTIFICATE, OAUTH2, JWT, KERBEROS.
authenticationType: ""
query:
# -- Should be the same or slightly less than worker.resources memory values if set
maxMemory: "4GB"
exchangeManager: {}
# server.exchangeManager -- Mandatory [exchange manager
Expand Down Expand Up @@ -569,14 +570,17 @@ coordinator:
# coordinator.deployment.strategy -- The deployment strategy to use to replace existing pods with new ones.

jvm:
# -- Should be around 70% of coordinator.resources memory values if set
maxHeapSize: "8G"
gcMethod:
type: "UseG1GC"
g1:
# -- Should be around 10% of coordinator.resources memory values if set
heapRegionSize: "32M"

config:
memory:
# -- Should be around 30% of coordinator.resources memory values if set
heapHeadroomPerNode: ""
nodeScheduler:
includeCoordinator: false
Expand All @@ -585,6 +589,7 @@ coordinator:
# coordinator can negatively impact query performance because the machine's resources are not available for the
# critical coordinator tasks of scheduling, managing, and monitoring query execution.
query:
# -- Should be around 20% of coordinator.resources memory values if set
maxMemoryPerNode: "1GB"

additionalJVMConfig: []
Expand Down Expand Up @@ -754,16 +759,20 @@ worker:
# worker.deployment.strategy -- The deployment strategy to use to replace existing pods with new ones.

jvm:
# -- Should be around 70% of worker.resources memory values if set
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should link the Trino docs here (like these) instead of specifying concrete values.

maxHeapSize: "8G"
gcMethod:
type: "UseG1GC"
g1:
# -- Should be around 10% of worker.resources memory values if set
heapRegionSize: "32M"

config:
memory:
# -- Should be around 30% of worker.resources memory values if set
heapHeadroomPerNode: ""
query:
# -- Should be around 20% of worker.resources memory values if set
maxMemoryPerNode: "1GB"

additionalJVMConfig: []
Expand Down