-
Notifications
You must be signed in to change notification settings - Fork 73
Document using colon instead of equals sign in session properties #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -349,6 +349,23 @@ func waitForContainerHealth(containerID, containerName string) { | |
} | ||
} | ||
|
||
func waitForTrinoReady(t *testing.T, db *sql.DB) { | ||
if err := pool.Retry(func() error { | ||
row := db.QueryRow("SELECT count(*) FROM system.runtime.nodes WHERE state = 'active'") | ||
var count int | ||
if row.Scan(&count) != nil { | ||
t.Logf("Failed to query nodes: %v", row.Err()) | ||
return errors.New("Not ready") | ||
} | ||
if count > 0 { | ||
return nil | ||
} | ||
return errors.New("Not ready") | ||
}); err != nil { | ||
log.Fatal("Timed out waiting for Trino to be ready") | ||
} | ||
} | ||
|
||
func generateCerts(dir string) error { | ||
priv, err := rsa.GenerateKey(rand.Reader, 2048) | ||
if err != nil { | ||
|
@@ -474,6 +491,7 @@ func integrationOpen(t *testing.T, dsn ...string) *sql.DB { | |
if err != nil { | ||
t.Fatal(err) | ||
} | ||
waitForTrinoReady(t, db) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This method should not be receiving Also, it because it queries the system catalog, it makes some tests redundant, like In any case, this should be done in a separate commit. How does the failure manifest itself? We use a single node instance in these tests. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Regarding the recent changes to the integration test logic: Reason for modification CI pipeline issue |
||
return db | ||
} | ||
|
||
|
Uh oh!
There was an error while loading. Please reload this page.