Skip to content

feat: extra headers during initialization #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
regadas merged 3 commits into from
Nov 5, 2024
Merged

feat: extra headers during initialization #668

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d5f6b83
feat: extra headers during initialization
aderihoJD Sep 24, 2024
c12d44e
Add test
regadas Nov 5, 2024
4bd7104
make it readonly
regadas Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ export type ConnectionOptions = {
readonly session?: Session;
readonly extraCredential?: ExtraCredential;
readonly ssl?: SecureContextOptions;
extraHeaders?: RequestHeaders;
};

export type QueryStage = {
Expand Down Expand Up @@ -192,6 +193,7 @@ class Client {
[TRINO_EXTRA_CREDENTIAL_HEADER]: encodeAsString(
options.extraCredential ?? {}
),
...(options.extraHeaders ?? {}),
};

if (options.auth && options.auth.type === 'basic') {
Expand Down
16 changes: 16 additions & 0 deletions tests/it/client.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,22 @@ describe('trino', () => {
expect(info.query).toBe(singleCustomerQuery);
});

test.concurrent('client extra header propagation', async () => {
const source = 'new-client';
const trino = Trino.create({
catalog: 'tpcds',
schema: 'sf100000',
auth: new BasicAuth('test'),
extraHeaders: {'X-Trino-Source': source},
});

const query = await trino.query(singleCustomerQuery);
const qr = await query.next();

const info: any = await trino.queryInfo(qr.value.id);
expect(info.session.source).toBe(source);
});

test.concurrent('query request header propagation', async () => {
const trino = Trino.create({catalog: 'tpcds', auth: new BasicAuth('test')});
const query = await trino.query(useSchemaQuery);
Expand Down