Allows override X-Trino-User from extraHeaders

[viethqb]

Problem
Currently, TRINO_USER_HEADER (X-Trino-User) is always set to basic.username and cannot be overridden via extraHeaders. This prevents using Trino's impersonation feature.

Solution
Change the priority order for setting the X-Trino-User header:

Use value from extraHeaders if provided

Fall back to basic.username

Summary by Sourcery

Enhancements:

• Enable X-Trino-User header to be sourced from extraHeaders before defaulting to the basic.username

[cla-bot]

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The pull request updates the header assignment logic in Client to allow the X-Trino-User header to be overridden via extraHeaders, falling back to the basic.username only when no override is provided.

Sequence diagram for X-Trino-User header assignment in Client.connect

sequenceDiagram
participant Client
participant "extraHeaders"
participant "basic.username"
Client->>"extraHeaders": Check for X-Trino-User
alt X-Trino-User in extraHeaders
    Client->>Client: Set X-Trino-User from extraHeaders
else X-Trino-User not in extraHeaders
    Client->>"basic.username": Use basic.username for X-Trino-User
end

Loading

Class diagram for updated Client header logic

classDiagram
class Client {
  +connect(options)
  -basic: object
  -clientConfig: object
}
Client : +connect(options)
Client : -headers: object
Client : -TRINO_USER_HEADER: string
Client : "X-Trino-User header set from extraHeaders or basic.username"

Loading

File-Level Changes

Change	Details	Files
Allow X-Trino-User header override via extraHeaders	Changed TRINO_USER_HEADER assignment to use options.extraHeaders value first Fell back to basic.username if no override provided	src/index.ts

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}